...
This is complicated by the fact that the char
data type might, in any implementation, be signed or unsigned.
Non-Compliant Code Example
This non-compliant code example may pass illegal values to the ctype
functions.
Code Block |
---|
size_t count_whitespace(const char *s) { const char *t = s; while(isspace(*t)) /* possibly *t < 0 */ ++t; return t - s; } |
Compliant Solution 1
Pass character strings around explicitly using unsigned characters.
...
This approach is inconvenient when you need to interwork with other functions that haven't been designed with this approach in mind, for example, the string handling functions found in the standard library.
Compliant Solution 2
This compliant solution uses an explicit cast.
Code Block |
---|
size_t count_whitespace(const char *s) { const char *t = s; while(isspace((unsigned char)*t)) ++t; return t - s; } |
Priority: P3 Level: L3
Component | Value |
---|---|
Severity | 1 (low) |
Likelihood | 1 (unlikely) |
Remediation cost | 3 (low) |
References
- ISO/IEC 9899-1999 Section 7.4 Character handling <ctype.h>
- Kettlewell 02 Section 1.1 <ctype.h> And Characters Types