Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Reusing variable names leads to programmer confusion about which variable is being modified.  Additionally, if variable names are reused, generally one or both of the variable names are too generic.

Non-compliant Code Example 1

In the following example, the programmer sets the value of the msg variable expecting to reuse that outside the block. Due to the reuse of the same variable name, however, the outside msg variable value is not changed.

Code Block
char msg[100];
{
      char msg[80] = "Hello";
      strcpy(msg, "Error");
}

printf ("%s\n", msg);

 

Exceptions

 When the block is small, although still not desirable, the danger of reusing variable names is mitigated by the visibility of the immediate declaration.