Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

The getenv() function searches an environment list for a string that matches a specified name, and returns a pointer to a string associated with the matched list member. Due to the way environment variables are stored, multiple environment variables with the same name can cause unexpected results. You may end up checking one value, but actually returning another.

Implementation Details

Depending on the implementation, a program may not consistently choose the same value if there are multiple environment variables with the same name. The GNU glibc library attempts to deal with this issue in getenv() and setenv() by always using the first variable it comes across, and ignoring the rest. unsetenv() will remove all the entries matching the variable name. Other implementations are following this lead.

Non-Compliant Coding Example

Do not use different methods to get environment variables, as you may end up checking one value, but actually returning another.

Compliant Solution

The glibc getenv() and setenv() functions will always choose the same value, so using them is a good option.

#ccccff
Code Block
bgColor
char *temp;
char *copy;

if ((temp = getenv("TEST_ENV")) != NULL) {
  copy= malloc(strlen(temp) + 1);
  if (copy != NULL) {
    strcpy(copy, temp);
  }
  else {
    /* handle error condition */
  }

  copy[0] = 'a';
  setenv("TEST_ENV", copy, 1);
}
else {
  return -1;
}

...