Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Code Block
bgColor#FFCCCC
langc
char *file_name;
FILE *fp;

/* initializeInitialize file_name */

fp = fopen(file_name, "w");
if (!fp){
  /* Handle error */
}

...

The C11 Annex K function fopen_s() can be used to create a file with restricted permissions [ISO/IEC 9899:2011]:

If the file is being created, and the first character of the mode string is not 'u', to the extent that the underlying system supports it, the file shall have a file permission that prevents other users on the system from accessing the file. If the file is being created and the first character of the mode string is 'u', then by the time the file has been closed, it shall have the system default file access permissions.

The u character can be thought of as standing for "umask," meaning that these are the same permissions that the file would have been created with had it been created by fopen(). In this compliant solution, the u mode character is omitted so that the file is opened with restricted privileges (regardless of the umask):

...

On Windows, fopen_s() will create the file with security permissions based on the user executing the application.   For more controlled permission schemes, consider using the CreateFile() function , and specifying the SECURITY_ATTRIBUTES parameter.

...

Using the POSIX open() function to create a file but failing to provide access permissions for that file may cause the file to be created with overly permissive access permissions. This omission has been known to lead to vulnerabilities—for vulnerabilities—for example, CVE-2006-1174.

Code Block
bgColor#FFCCCC
langc
char *file_name;
int fd;

/* initializeInitialize file_name */

fd = open(file_name, O_CREAT | O_WRONLY);
/* accessAccess permissions were missing */

if (fd == -1){
  /* Handle error */
}

...

Recommendation

Severity

Likelihood

Remediation Cost

Priority

Level

FIO06-C

mediumMedium

probableProbable

highHigh

P4

L3

Automated Detection

Tool

Version

Checker

Description

PRQA QA-C
Include Page
PRQA_V
PRQA_V
warncall fopenPartially implemented

...

CERT C++ Secure Coding StandardFIO06-CPP. Create files with appropriate access permissions
CERT Oracle Secure Coding Standard for JavaFIO01-J. Create files with appropriate access permissions
ISO/IEC TR 24772:2013Missing or Inconsistent Access Control [XZN]
MITRE CWECWE-276, Insecure default permissions
CWE-279, Insecure execution-assigned permissions
CWE-732, Incorrect permission assignment for critical resource

...

[CVE] 
[Dowd 2006]Chapter 9, "UNIX 1: Privileges and Files"
[ISO/IEC 9899:2011]Annex Subclause K.3.5.2.1, "The fopen_s Function"
[OpenBSD] 
[Open Group 2004]"The open Function"
"The umask Function"
[Viega 2003]Section 2.7, "Restricting Access Permissions for New Files on UNIX"

...