Page History

...

This recommendation is a specific case of guideline MSC12-C. Detect and remove code that has no effect.

...

In this example, p2 is assigned the value returned by bar(), but that value is never used. Note this example assumes that foo() and bar() return valid pointers. (See rule DCL30-C. Declare objects with appropriate storage durations.)

int *p1, *p2;
p1 = foo();
p2 = bar();

if (baz()) {
  return p1;
}
else {
  p2 = p1;
}
return p2;

Compliant Solution

This example can be corrected corrected in many different ways, depending on the intent of the programmer. In this compliant solution, p2 is found to be extraneous. The calls to bar() and baz() can be removed if they do not produce any side effects.

int *p1 = foo();

/* Removable if bar() does not produce any side effects */
(void)bar();

/* Removable if baz() does not produce any side effects */
(void)baz();
return p1;

...

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

...

ISO/IEC TR 24772 "BRS Leveraging human experience," "KOA Likely incorrect expressions," "XYQ Dead and Deactivated Codedeactivated code," and "XYR Unused Variablevariable"

...

Sources

[Coverity 2007]

...