...
Attempting to access an object outside of its lifetime could result in an exploitable vulnerability.
Non-Compliant Code Example
...
(Global Variables)
This non-compliant code example declares the variable p
as a pointer to a constant char
with file scope. The value of str
is assigned to p
within the dont_do_this()
function. However, str
has automatic storage duration so the lifetime of str
ends when the dont_do_this()
function exits.
...
As a result of this undefined behavior, it is likely that p
will refer to the string literal "Surprise, surprise"
after the call to the innocuous()
function.
Compliant Solution (p
with
...
block scope)
In this compliant solution, p
is set to NULL
just before str
goes out of scope. This prevents declared with the same scope as str
, preventing p
from taking on an indeterminate value outside of this_is_OK()
.
Code Block | ||
---|---|---|
| ||
void this_is_this_OK() { char const str[] = "Everything OK?"; char const *p = str; /* ... */ } /* pointer p is now inaccessible outside the scope of pstring = NULL; }str */ |
Compliant Solution (p
with
...
file scope)
Alternatively, this example can be corrected by declaring p
with the same scope as str
. This approach also If it is necessary for p
to be defined with file scope, it can be set to NULL
before str
is destroyed. This prevents p
from taking on an indeterminate value, although any references to p
must check for NULL
.
Code Block | ||
---|---|---|
| ||
void is_this_is_OK() { char const str[] = "Everything OK?"; char const *p = str; /* ... */ } /* pointer p is nowp inaccessible outside the scope of string str */= NULL; } |
Non-Compliant Code Example
...
(Return Values)
In this example, the function init_array()
incorrectly returns a pointer to a local stack variable.
...
On some compilers, compiling with sufficiently high warning levels will generate a warning when a local stack variable is returned from a function.
Compliant Solution
...
(Return Values)
Correcting this example depends on the intent of the programmer. If the intent is to modify the value of array
and have that modification persist outside of the scope of init_array()
, then the desired behavior can be achieved by declaring array
elsewhere and passing it as a parameter an argument to init_array()
.
Code Block | ||
---|---|---|
| ||
char array[10];
/* ... */
void init_array(char array[]) {
/* Initialize array */
return;
}
|
...