Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Expanded to cover VLAs.

The sizeof operator yields the size (in bytes) of its operand, which may be an expression or the parenthesized name of a type. If When the type of the operand is not a variable-length array type , (VLA) the expression is evaluated; otherwise the operand is not evaluated.

When part of the operand of the sizeof operator is a VLA type and when changing the value of the VLA's size expression would not affect the result of the operator, it is unspecified whether or not the size expression is evaluated. See unspecified behavior 21 in section J.1 of C99.

Providing an expression that appears to produce side effects may be misleading to programmers who are not aware that these expressions are not evaluated in the non-VLA case and has unspecified results otherwise. As a result, programmers may make invalid assumptions about program state, leading to errors and possible software vulnerabilities.

...

Code Block
bgColor#ccccff
int a = 14;
int b = sizeof(a);
a++;

Anchor
ncce_vla
ncce_vla

Noncompliant Code Example (Variable Length Array)

In the following noncompliant code example the expression ++n in the initialization expression of a must be evaluated since its value affects the size of the variable length array operand of the sizeof operator. However, since the expression ++n % 1 evaluates to 0 regardless of the value of n its value does not affect the result of the sizeof operator and thus it is unspecified whether n is incremented or not.

Code Block
bgColor#FFcccc

void f(size_t n) {
  size_t a = sizeof(int [++n]);           /* n must be incremented */
  size_t b = sizeof(int [++n % 1 + 1]);   /* n need not be incremented */
  /* ... */
}

Anchor
cs_vla
cs_vla

Compliant Solution (Variable Length Array)

The compliant solution below avoids changing the value of the variable n used in the sizeof expression and instead increments it safely outside of it.

Code Block
bgColor#ccccFF

void f(size_t n) {
  size_t a = sizeof(int [n + 1]);
  ++n;

  size_t b = sizeof(int [n % 1 + 1]);
  ++n;
  /* ... */
}

Risk Assessment

If expressions that appear to produce side effects are supplied to the sizeof operator, the returned result may be different than expected. Depending on how this result is used, this can lead to unintended program behavior.

...