...
Wiki Markup |
---|
The general contract for {{compareTo()}} from Java SE 6 API \[[API 2006|AA. References#API 06]\] states that |
- The implementor must ensure
sgn(x.compareTo(y)) == -sgn(y.compareTo(x))
for allx
andy
. (This implies thatx.compareTo(y)
must throw an exception ify.compareTo(x)
throws an exception.)- The implementor must also ensure that the relation is transitive:
(x.compareTo(y) > 0 && y.compareTo(z) > 0)
impliesx.compareTo(z) > 0
.- Finally, the implementor must ensure that
x.compareTo(y) == 0
implies thatsgn(x.compareTo(z)) == sgn(y.compareTo(z))
for allz
.- It is strongly recommended, but not strictly required, that
(x.compareTo(y) == 0) == x.equals(y)
. Generally speaking, any class that implements the Comparable interface and violates this condition should clearly indicate this fact. The recommended language is Note: this class has a natural ordering that is inconsistent with equals.In the foregoing description, the notation
sgn(expression)
designates the mathematical signum function, which is defined to return either -1, 0, or 1 depending on whether the value of the expression is negative, zero or positive.
...
However, this game violates the required transitivity property because rock beats scissors, scissors beats paper, but sock rock does not beat paper.
Compliant Solution (Rock-Paper-Scissors)
...
CWE-573. Improper following of specification by caller |
...
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="54fa7e1c81f8c017-67a4ae54-49974fc2-bc15a1e7-500ba47dbd11c2df11a6f68d"><ac:plain-text-body><![CDATA[ | [[API 2006 | AA. References#API 06]] | [Method | http://java.sun.com/javase/6/docs/api/java/lang/Comparable.html#compareTo(java.lang.Object)] | ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="178e8636d4abcfec-9edd7d10-47cf4652-b5de8e69-6e36a627c2986959a9894fe0"><ac:plain-text-body><![CDATA[ | [[JLS 2005 | AA. References#JLS 05]] |
| ]]></ac:plain-text-body></ac:structured-macro> |
...