...
Examples of sensitive data that should not be serialized are cryptographic keys, digital certificates, and classes that may hold references to sensitive data at the time of serialization.
...
Code Block | ||
---|---|---|
| ||
public class Point { private double x; private double y; public Point(double x, double y) { this.x = x; this.y = y; } public Point() { // No argument constructor } } public class Coordinates extends Point implements Serializable { public static void main(String[] args) { try { Point p = new Point(5, 2); FileOutputStream fout = new FileOutputStream("point.ser"); ObjectOutputStream oout = new ObjectOutputStream(fout); oout.writeObject(p); oout.close(); } catch (Throwable t) { /*/ Forward to handler */ } } } |
Compliant Solution
In the absence of sensitive data, a class can be serialized by implementing the java.io.Serializable
interface (sensitive classes should not implement this interface). By doing so, the class indicates that no security issues may result from the object's serialization. Note that any derived sub classes also inherit this interface and are consequently serializable.
When serialization is unavoidable, it is still possible to have classes that cannot implement serializable effectively. This condition is common Usually, this happens when there are references to non-serializable objects within the contained methods. The following serializable class. This compliant solution avoids this issue the possibility of incorrect serialization and also protects sensitive data members from getting being serialized accidentally. The basic idea is to declare the target member as transient
so that it is not included in the list of fields to be serialized, whenever default serialization is being used.
Code Block | ||
---|---|---|
| ||
public class Point { private transient double x; // declared transient private transient double y; // declared transient public Point(double x, double y) { this.x = x; this.y = y; } public Point() { //no argument constructor } } public class Coordinates extends Point implements Serializable { public static void main(String[] args) { try { Point p = new Point(5,2); FileOutputStream fout = new FileOutputStream("point.ser"); ObjectOutputStream oout = new ObjectOutputStream(fout); oout.writeObject(p); oout.close(); } catch (Exception e) { // Forward to handler } } } |
Other solutions include using custom implementation of writeObject()
, writeReplace()
and writeExternal()
methods so that sensitive fields are not written to the serialized stream or alternatively, conducting proper validation checks while deserializing. Yet another remedy is to define the serialPersistentFields
array field and ensuring that sensitive fields are not added to the array (SER00-J. Maintain serialization compatibility during class evolution). Sometimes it is necessary to prevent a serializable object (whose superclass implements serializable Serializable
) from getting being serialized. This is the focus of the second noncompliant code example.
...
Wiki Markup |
---|
Serialization can also be used maliciously, to return multiple instances of a singleton-like class. In this noncompliant code example, a subclass {{SensitiveClass}} inadvertently becomes serializable as it extends the {{Exception}} class that implements {{Serializable}}. (Based on \[[Bloch 05|AA. Java References#Bloch 05]\]) |
Code Block | ||
---|---|---|
| ||
public class SensitiveClass extends Exception { public static final SensitiveClass INSTANCE = new SensitiveClass(); private SensitiveClass() { // Perform security checks and parameter validation } protected int printBalance() { int balance = 1000; return balance; } } class Malicious { public static void main(String[] args) { SensitiveClass sc = (SensitiveClass) deepCopy(SensitiveClass.INSTANCE); System.out.println(sc == SensitiveClass.INSTANCE); // Prints false; indicates new instance System.out.println("Balance = " + sc.printBalance()); } // This method should not be used in production quality code static public Object deepCopy(Object obj) { try { ByteArrayOutputStream bos = new ByteArrayOutputStream(); new ObjectOutputStream(bos).writeObject(obj); ByteArrayInputStream bin = new ByteArrayInputStream(bos.toByteArray()); return new ObjectInputStream(bin).readObject(); } catch (Exception e) { throw new IllegalArgumentException(e); } } } |
Compliant Solution
Undue Ideally, extending a class or interface that implements Serializable
should be avoided. When this is not possible, undue serialization of the subclass can be prohibited by throwing a NotSerializableException
from a custom writeObject()
method or the readResolve()
method, defined in the subclass SensitiveClass
. Ideally, extending a class or interface that implements Serializable
should be avoided. It is also required to declare the methods final
to prevent a malicious subclass from overriding them.
...
If sensitive data can be serialized then , it may be transmitted over an insecure link, or stored in an insecure medium, and thereby released or disclosed inappropriately.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
SER03- J | medium | likely | high | P6 | L2 |
...