SEI CERT Oracle Coding Standard for Java

Space shortcuts

Page tree

Versions Compared

Old Version 32

changes.mady.by.user Dhruv Mohindra

Saved on

compared with

New Version 33

changes.mady.by.user Ankur Goyal

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Edited by sciSpider Java v3.0

Wiki Markup
Programmers frequently make errors regarding the precedence rules of operators due to the unintuitive low-precedence levels of {{&amp;}}, {{\|}}, {{\^}}, {{<<&lt;&lt;}}, and {{>>&gt;&gt;}}. Mistakes regarding precedence rules can be avoided by the suitable use of parentheses. Defensive use of parentheses, if not taken to excess, also improves code readability. The precedence of operations by the order of the subclauses are defined in the Java Tutorials \[[Tutorials 08|AA. Java References#Tutorials 08]\].

...

Code Block
bgColor#FFCCCC
public static final int MASK = 1337;
public static final int OFFSET = -1337;

public static int computeCode(int x) {
  return x &amp; MASK + OFFSET;
}

According to the operator precedence rules, the expression is parsed as:

Code Block
x &amp; (MASK + OFFSET)

This expression gets evaluated as shown below, resulting in the value 0.

Code Block
x &amp; (1337 - 1337)

Compliant Solution

...

Code Block
bgColor#ccccff
public static final int MASK = 1337;
public static final int OFFSET = -1337;

public static int computeCode(int x) {
  return (x &amp; MASK) + OFFSET;
}

Exceptions

...

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Other Languages

This rule appears in the C Coding Standard as EXP00-C. Use parentheses for precedence of operation.

...

EXP08-J. Be aware of integer promotions in binary operators      &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;04. Expressions (EXP)      &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;EXP30-J. Do not depend on operator precedence while using expressions containing side-effects