...
Wiki Markup |
---|
The general usage contract for {{compareTo()}} from Java SE 6 API \[[API 2006|AA. Bibliography#API 06], (numbering added\]) states that |
- The implementor must ensure
sgn(x.compareTo(y)) == -sgn(y.compareTo(x))
for allx
andy
. (This implies thatx.compareTo(y)
must throw an exception iff ify.compareTo(x)
throws an exception.)- The implementor must also ensure that the relation is transitive:
(x.compareTo(y) > 0 && y.compareTo(z) > 0)
impliesx.compareTo(z) > 0
.- Finally, the implementor must ensure that
x.compareTo(y) == 0
implies thatsgn(x.compareTo(z)) == sgn(y.compareTo(z))
, for allz
.- It is strongly recommended, but not strictly required, that
(x.compareTo(y) == 0) == x.equals(y)
. Generally speaking, any class that implements the Comparable interface and violates this condition should clearly indicate this fact. The recommended language is " Note: this class has a natural ordering that is inconsistent with equals."In the foregoing description, the notation
sgn(expression)
designates the mathematical signum function, which is defined to return either -1, 0, or 1 depending on whether the value of the expression is negative, zero or positive.
Never Implementations must never violate any of the first three conditions when implementing the compareTo()
method. Implementations should conform to the fourth condition whenever possible.
...
However, this game violates the notion of required transitivity property because Rock rock beats Scissorsscissors, Scissors scissors beats Paperpaper, but Rock sock does not beat Paperpaper.
Compliant Solution (Rock-Paper-Scissors)
This compliant solution implements the same game but does not use without using the Comparable
interface.
Code Block | ||
---|---|---|
| ||
class GameEntry { public enum Roshambo {ROCK, PAPER, SCISSORS} private Roshambo value; public GameEntry(Roshambo value) { this.value = value; } public int beats(Object that) { if (!(that instanceof Roshambo)) { throw new ClassCastException(); } GameEntry t = (GameEntry) that; return (value == t.value) ? 0 : (value == Roshambo.ROCK && t.value == Roshambo.PAPER) ? -1 : (value == Roshambo.PAPER && t.value == Roshambo.SCISSORS) ? -1 : (value == Roshambo.SCISSORS && t.value == Roshambo.ROCK) ? -1 : 1; } } |
...
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
MET10-J | medium | unlikely | medium | P4 | L3 |
Automated Detection
The Coverity Prevent Version 5.0 MUTABLE_COMPARISON checker Some static analysis tools can detect cases where the instances where compareTo()
method is reading reads from a non-constant nonconstant field. If the non-constant nonconstant field is were modified, the value of compareTo()
might change, which may would break program invariants.
...
CWE-573, ". Improper Following following of Specification specification by Caller" caller |
Bibliography
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="07ec7f24adefb103-cd41b438-43894df3-a2ff8dc4-290003c2025e599215650560"><ac:plain-text-body><![CDATA[ | [[API 2006 | AA. Bibliography#API 06]] | method [Method | http://java.sun.com/javase/6/docs/api/java/lang/Comparable.html#compareTo(java.lang.Object)] | ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="eec6cbdc9f1138f0-e1e74e6e-4596409e-804fb319-19d16e9e1db298715636062a"><ac:plain-text-body><![CDATA[ | [[JLS 2005 | AA. Bibliography#JLS 05]] |
| ]]></ac:plain-text-body></ac:structured-macro> |
...