Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Edited by NavBot

...

Code Block
public class BadFile extends java.io.File {
  private int count;
  public String getPath() {
    return (++count == 1) ? ""/tmp/foo"" : ""/etc/passwd"";
  }
}

Compliant Solution

Security checks should not be based on untrusted sources. This compliant solution ensures that the java.io.File object cannot be untrusted. This is achieved by declaring java.io.File as final and ensuring that a new java.io.File object is created in the openFile() method. Note that using the clone() method instead, would copy the attacker's class which is not desirable (refer to MET39-J. Do not use the clone method to copy untrusted method parameters).

...

Wiki Markup
\[[Sterbenz 06|AA. Java References#Sterbenz 06]\] 
\[[MITRE 09|AA. Java References#MITRE 09]\] [CWE ID 302|http://cwe.mitre.org/data/definitions/302.html] ""Authentication Bypass by Assumed-Immutable Data""

...

SEC34-J. Do not allow tainted variables in doPrivileged blocks            02. Platform Security (SEC)      03. Declarations and Initialization (DCL)      SEC36-J. Enforce security checks in code that performs sensitive operations