Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Wiki Markup
            Native methods are defined in Java and written in traditional languages such as C and C++ \[[JNI 2006|AA. Bibliography#JNI 06]\]. The added extensibility comes at the cost of flexibility and portability because the code no longer conforms to the policies enforced by Java. InNative themethods past,have nativebeen methods were used for performing platform-specific operations, interfacing with legacy library code, and improving program performance \[[Bloch 2008|AA. Bibliography#Bloch 08]\]. Although this is no longer completely true --- because of poor portability, security, and (ironically) performance issues --- native code is still used to interface with legacy code.

Defining a wrapper method facilitates installing appropriate security manager checks, performing input validation before passing the arguments to the native code or when obtaining validating arguments passed to native code, validating return values, defensively copying mutable inputs, and sanitizing untrusted data. Consequently, every native method must be private and must be invoked only by a wrapper method.

...

In this noncompliant code example, the nativeOperation() method is both native and public; for that reasontherefore, untrusted callers may invoke it. Native method invocations bypass security manager checks.

...

This compliant solution declares the native method private. The doOperation() wrapper method performs routine permission checking to determine whether the succeeding operations are permitted to continue. The method also checks permissions, creates a defensive copy of the mutable input array data, as well as performing range checking and checks the ranges of the arguments. The nativeOperation() method is consequently called with safe secure inputs. Note that the validation checks must produce outputs that conform to the input requirements of the native methods.

Code Block
bgColor#ccccff
public final class NativeMethodWrapper {

  // private native method
  private native void nativeOperation(byte[] data, int offset, int len);

  // wrapper method performs SecurityManager and input validation checks
  public void doOperation(byte[] data, int offset, int len) {
    // permission needed to invoke native method
    securityManagerCheck();

    if (data == null) {
      throw new NullPointerException();
    }

    // copy mutable input
    data = data.clone();

    // validate input
    if ((offset < 0) || (len < 0) || (offset > (data.length - len))) {
      throw new IllegalArgumentException();
    }

    nativeOperation(data, offset, len);
  }

  static {
    // load native library in static initializer of class
    System.loadLibrary("NativeMethodLib"); 
  }
}

Exceptions

SEC08-EX00EX0: Native methods that do not require security manager checks, validation of arguments or return values, or defensive copying of mutable inputs do not need to be wrapped ((for example, the standard C function int rand(void), for example)) do not need to be wrapped.

Risk Assessment

Failure to define wrappers around native methods can allow unprivileged callers to invoke them and consequently exploit inherent vulnerabilities such as those resulting from invalid inputsbuffer overflows in native libraries.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

SEC08-J

medium

probable

high

P4

L3

...

Related Guidelines

MITRE CWE

CWE-111, ". Direct Use use of Unsafe unsafe JNI "

Secure Coding Guidelines for the Java Programming Language, Version 3.0

Guideline 3-3. Define wrappers around native methods

...

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="914a55bff1a2767a-20acf37d-468341fb-a9a49e8b-d840152a814c6fc5c2c82912"><ac:plain-text-body><![CDATA[

[[Fairbanks 2007

AA. Bibliography#Fairbanks 07]]

 

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="299301c7e7fb836e-7c512a26-43ac4623-881e96e2-a4a5dc4ba1249de4b3b29866"><ac:plain-text-body><![CDATA[

[[JNI 2006

AA. Bibliography#JNI 06]]

 

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="3f18e38344f5e7fe-b6f33908-40dd42cc-b65097c7-8ff93c93684378d7885c94a3"><ac:plain-text-body><![CDATA[

[[Liang 1997

AA. Bibliography#Liang 97]]

 

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="8e728eda6756f5fc-d9b8149d-44744050-869386b8-0053de65f125e4a498fb485f"><ac:plain-text-body><![CDATA[

[[Macgregor 1998

AA. Bibliography#Macgregor 98]]

Section 2.2.3, Interfaces and Architectures

]]></ac:plain-text-body></ac:structured-macro>

...