Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

This noncompliant code example performs some basic currency calculations.:

Code Block
bgColor#FFcccc
double dollar = 1.00;
double dime = 0.10;
int number = 7;
System.out.println(
  "A dollar less " + number + " dimes is $" + (dollar - number * dime) 
);

Because the value 0.10 lacks an exact representation in either Java floating-point type (or any floating-point format that uses a binary mantissa), on most platforms, this program prints the following:

Code Block
A dollar less 7 dimes is $0.29999999999999993

...

This compliant solution uses an integer type (such as int) and works with cents rather than dollars.:

Code Block
bgColor#ccccff
int dollar = 100;
int dime = 10;
int number = 7;
System.out.println(
  "A dollar less " + number + " dimes is $0." + (dollar - number * dime)
);

This code correctly outputs the following:

Code Block
A dollar less 7 dimes is $0.30

...

Code Block
bgColor#ccccff
import java.math.BigDecimal;

BigDecimal dollar = new BigDecimal("1.0");
BigDecimal dime = new BigDecimal("0.1");
int number = 7;
System.out.println ("A dollar less " + number + " dimes is $" +
	(dollar.subtract(new BigDecimal(number).multiply(dime) )) );

This code outputs the following:

Code Block
A dollar less 7 dimes is $0.3

...

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

NUM04-J

lowLow

probableProbable

highHigh

P2

L3

Automated Detection

Automated detection of floating-point arithmetic is straight forwardstraightforward. However, determining which code suffers from insufficient precision is not feasible in the general case. Heuristic checks, such as flagging floating-point literals that cannot be represented precisely, could be useful.

...

Android Implementation Details

The use of floating-point on Android is not recommended for performance reasons on Android.

Bibliography

 

...