SEI CERT Oracle Coding Standard for Java

Space shortcuts

Page tree

Versions Compared

Old Version 2

changes.mady.by.user David Svoboda

Saved on

compared with

New Version 3

changes.mady.by.user David Svoboda

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

In the following noncompliant code, unsafe characters are used as part of a file name.

Code Block
bgColor#ffcccc
#include <fcntl.h>
#include <sys/stat.h>

int main(void) {
   char *file_name = "&#xBB;&#xA3;???&#xAB;";
   mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH;

   int fd = open(file_name, O_CREAT | O_EXCL | O_WRONLY, mode);
   if (fd == -1) {
      /* Handle Error */
   }
}File f = new File("A\uD8AB");
OutputStream out = new FileOutputStream(f);

An implementation is free to define its own mapping of the non-"safe" characters. For example, when tested on a Red Hat an Ubuntu Linux distribution, this noncompliant code example resulted in the following file name:

Code Block
???A???

Compliant Solution: File Name

Use a descriptive file name, containing only the subset of ASCII previously described.

Code Block
bgColor#ccccff
#include <fcntl.h>
#include <sys/stat.h>

int main(void) {
   char *file_name = File f = new File("name.ext");
   mode_t modeOutputStream out = S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH;

   int fd = open(file_name, O_CREAT | O_EXCL | O_WRONLY, mode);
   if (fd == -1) {
      /* Handle Error */
   }
}new FileOutputStream(f);

Noncompliant Code Example (File Name)

...