This rule is a stub. It is also an instance of the guideline IDS00-J. Prevent SQL InjectionHTML allows fields in a web form to be visible or hidden. Hidden fields supply values to a web server but do not provide the user with a mechanism to modify their contents. However, there are techniques that attackers can use to modify these contents anyway. A web servlet that uses a GET form to obtain parameters can also accept these parameters through a URL. URLs allow a user to specify any parameter names and values in the web request. Consequently, hidden form fields should not be considered any more trustworthy than visible form fields.
Noncompliant Code Example
The following servlet noncompliant code example demonstrates a servlet that accepts a visible field and a hidden field, and echoes them back to the user. The visible parameter is sanitized before being passed to the browser, but the hidden field is not.
| Code Block | ||||
|---|---|---|---|---|
| ||||
public class SampleServlet extends HttpServlet {
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws IOException, ServletException {
response.setContentType("text/html");
PrintWriter out = response.getWriter();
out.println("<html>");
String visible = request.getParameter("visible");
String hidden = request.getParameter("hidden");
if (visible != null || hidden != null) {
out.println("Visible Parameter:");
out.println( sanitize( visible));
out.println("<br>Hidden Parameter:");
out.println( hidden);
} else {
out.println("<p>");
out.print("<form action=\"");
out.print("SampleServlet\" ");
out.println("method=POST>");
out.println("Parameter:");
out.println("<input type=text size=20 name=visible>");
out.println("<br>");
out.println("<input type=hidden name=hidden value=\'a benign value\'>");
out.println("<input type=submit>");
out.println("</form>");
}
}
/**
public void doPost(HttpServletRequest *request, FilterHttpServletResponse the specified message string for characters that are sensitiveresponse)
throws IOException, ServletException {
* in HTML. This avoids potential attacks caused by including JavaScript
* codes in the request URL that is often reported in error messages.
*
* @param message The message string to be filtered
*/
public static String sanitize(String message) {
if (message == null)
return null;
char content[] = new char[message.length()];
message.getChars(0, message.length(), content, 0doGet(request, response);
}
// Filter the specified message string for characters
// that are sensitive in HTML.
public static String sanitize(String message) {
// ...
}
}
|
When fed the parameter param1, the web page displays the following:
Visible Parameter: param1
Hidden Parameter: a benign value
However, an attacker can easily supply a value to the hidden parameter by encoding it in the URL as follows:
When this URL is provided to the browser, the browser displays:
Visible Parameter: dummy
Hidden Parameter: Surprise!!!
Compliant Solution
This compliant solution applies the same sanitization to the hidden parameter as is applied to the visible parameter:
| Code Block | ||||
|---|---|---|---|---|
| ||||
public class SampleServlet extends HttpServlet { public void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException { response.setContentType("text/html"); PrintWriter out = response.getWriter(); out.println("<html>"); String visible = request.getParameter("visible"); StringBuilderString resulthidden = new StringBuilder(content.length + 50);request.getParameter("hidden"); forif (intvisible i != 0;null i|| < content.length; i++hidden != null) { switch (content[i]) {out.println("Visible Parameter:"); case '<':out.println( sanitize(visible)); resultout.appendprintln("<<br>Hidden Parameter:"); out.println( sanitize(hidden)); break; // Hidden case '>':variable sanitized } else { result.append out.println("><p>"); breakout.print("<form action=\""); case '&':out.print("SampleServlet\" "); resultout.appendprintln("&method=POST>"); out.println("Parameter:"); break; out.println("<input case '"':type=text size=20 name=visible>"); resultout.appendprintln(""<br>"); out.println("<input type=hidden name=hidden value=\'a breakbenign value\'>"); default:out.println("<input type=submit>"); resultout.append(content[i]println("</form>"); } } public void return result.toString(); } } |
When fed the parameter param1, the web page displays the following:
Visible Parameter: param1
Hidden Parameter: a benign value
However, an attacker can easily supply a value to the hidden parameter by encoding it in the URL as follows:
When this URL is provided to the browser, the browser displays:
Visible Parameter: dummy
Hidden Parameter: Surprise!!!
Compliant Solution
This compliant solution applies the same sanitiation to the hidden parameter as is applied to the visible parameter:
| Code Block | ||||
|---|---|---|---|---|
| ||||
... if (visible != null || hidden != null) doPost(HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException { out.println("Visible Parameter:"doGet(request, response); } // Filter the specified message out.println( sanitize( visible)); out.println("<br>Hidden Parameter:"); out.println( sanitize( hidden));string for characters // that are sensitive in HTML. public static String sanitize(String message) { } else { // ... } } |
Consequently, when the malicious URL is entered into a browser, the servlet produces the following:
Visible Parameter: dummy
Hidden Parameter: <font color=red>Surprise</font>!!!
...
Trusting the contents of hidden form fields may lead to all sorts of nasty thingsproblems.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
|---|---|---|---|---|---|
IDS14-J | High | Probable | High | P6 | L2 |
Automated Detection
...
Tool | Version | Checker | Description | ||||||
|---|---|---|---|---|---|---|---|---|---|
| The Checker Framework |
| Tainting Checker | Trust and security errors (see Chapter 8) | ||||||
| CodeSonar |
| JAVA.IO.INJ.CODE | Code Injection (Java) | ||||||
| Fortify | 6.10.0120 | Hidden_Field | Implemented |
Bibliography
...
...