...
The C Standard, 6.3.1.4, paragraph 1 2 [ISO/IEC 9899:20112024], says,
When a finite value of real decimal floating type is converted to an integer type other than
_Bool
bool, the fractional part is discarded (i.e. , the value is truncated toward zero). If the value of the integral part cannot be represented by the integer type, the behavior is undefinedthe "invalid" floating-point exception shall be raised and the result of the conversion is unspecified.
Paragraph 2 of the same subclause says,
When a value of integer type is converted to a real standard floating type, if the value being converted can be represented exactly in the new type, it is unchanged. If the value being converted is in the range of values that can be represented but cannot be represented exactly, the result is either the nearest higher or nearest lower representable value, chosen in an implementation-defined manner. If the value being converted is outside the range of values that can be represented, the behavior is undefined.
And subclause 6.3.1.5, paragraph 1+2, says,
When a value of real floating type is converted to a real floating type, if the value being converted can be represented exactly in the new type, it is unchanged.
When a value of real floating type is converted to a standard floating type, if If the value being converted is in the range of values that can be represented but cannot be represented exactly, the result is either the nearest higher or nearest lower representable value, chosen in an implementation-defined manner. If the value being converted is outside the range of values that can be represented, the behavior is undefined.
See undefined behaviors 17 and 18.
...
Code Block | ||||
---|---|---|---|---|
| ||||
void func(float f_a) { int i_a; /* Undefined if the integral part of f_a cannot >= INT_MAXbe represented. */ i_a = f_a; } |
Compliant Solution (float
to int
)
This compliant solution ensures tests to ensure that the range of values of type float
is greater than that of an int
, as is the case in most implementations: float
value will fit within the int
variable before performing the assignment.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <float.h> #include <limits.h> #include <math.h> #include <float<stddef.h> #include <assert<stdint.h> extern size_t popcount(uintmax_t); /* See INT35-C */ #define PRECISION(umax_value) popcount(umax_value) void func(float f_a) { int i_a; if static_assert( (isnan(f_a) || PRECISION(double)INT_MAX) < log2f(fabsf(f_a)) || (f_a != 0.0F && fabsf(double)f_a) < FLT_MAXMIN)), { "not all/* intHandle valueserror can*/ be represented} aselse float"{ ); i_a = f_a; } } |
Noncompliant Code Example (Narrowing Conversion)
...
Code Block | ||||
---|---|---|---|---|
| ||||
#include <float.h> #include <math.h> void func(double d_a, long double big_d) { double d_b; float f_a; float f_b; if (d_a != 0.0 && (isnan(d_a) || isgreater(fabs(d_a), FLT_MAX) || isless(fabs(d_a), FLT_MIN))) { /* Handle error */ } else { f_a = (float)d_a; } if (big_d != 0.0 && (isnan(big_d) || isgreater(fabs(big_d), FLT_MAX) || isless(fabs(big_d), FLT_MIN))) { /* Handle error */ } else { f_b = (float)big_d; } if (big_d != 0.0 && (isnan(isgreater big_d) || isgreater(fabs(big_d), DBL_MAX) || isless(fabs(big_d), DBL_MIN))) { /* Handle error */ } else { d_b = (double)big_d; } } |
...
Converting a floating-point value to a floating-point value of a smaller range and precision or to an integer type, or converting an integer type to a floating-point type, can result in a value that is not representable in the destination type and is undefined behavior on implementations that do not support Annex F.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
FLP34-C | Low | Unlikely | Low | P3 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| Supported Astrée reports all potential overflows resulting from floating-point conversions. | |||||||
Compass/ROSE |
Can detect some violations of this rule. However, it does not flag implicit casts, only explicit ones | |||||||||
CodeSonar |
| LANG.TYPE.IAT | Inappropriate Assignment Type | ||||||
| MISRA_CAST (needs verification) | Can detect instances where implicit float conversion is involved: implicitly converting a complex expression with integer type to floating type, implicitly converting a double expression to narrower float type (may lose precision), implicitly converting a complex expression from |
5.0
Can detect violations of this rule with CERT C Rule Pack
Helix QAC |
| C4450, C4451, C4452, C4453, C4454, C4462, C4465 C++3011 | |||||||
Klocwork |
| MISRA.CAST.FLOAT.WIDER | |||||||
LDRA tool suite |
| 435 S, 93 S | Partially implemented | ||||||
Parasoft C/C++test |
| CERT_C-FLP34-a CERT_C-FLP34-b | Avoid implicit conversions from wider to narrower floating type | ||||||
PC-lint Plus |
| 735, 736, | Partially supported | ||||||
Polyspace Bug Finder |
| Checks for float conversion overflow (rule partially covered) | |||||||
PVS-Studio |
| V615, V2003, V2004 | |||||||
TrustInSoft Analyzer |
| float_to_int | Exhaustively verified (see one compliant and one non-compliant example). |
4450
4451
4452
4453
4454
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
Key here (explains table format and definitions)
Taxonomy | Taxonomy item | Relationship |
---|
CERT Oracle Secure Coding Standard for Java | NUM12-J. Ensure conversions of numeric types to narrower types do not result in lost or misinterpreted data | Prior to 2018-01-12: CERT: Unspecified Relationship |
ISO/IEC TR 24772:2013 | Numeric Conversion Errors [FLC] |
Prior to 2018-01-12: CERT: Unspecified Relationship | ||
CWE 2.11 | CWE-681, Incorrect Conversion between Numeric Types | 2017-06-29: CERT: Rule subset of CWE |
CWE 2.11 | CWE-197 | 2017-06-14: CERT: Rule subset of CWE |
CERT-CWE Mapping Notes
Key here for mapping notes
CWE-197 and FLP34-C
Independent( FLP34-C, INT31-C) FIO34-C = Subset( INT31-C)
CWE-197 = Union( FLP34-C, INT31-C)
CWE-195 and FLP34-C
Intersection( CWE-195, FLP34-C) = Ø
Both conditions involve type conversion. However, CWE-195 explicitly focuses on conversions between unsigned vs signed types, whereas FLP34-C focuses on floating-point arithmetic.
CWE-681 and FLP34-C
CWE-681 = Union( FLP34-C, INT31-C)
Bibliography
[IEEE 754 |
2006] |
[ISO/IEC 9899: |
2024] | Subclause 6.3.1.4, "Real Floating and Integer" Subclause 6.3.1.5, "Real Floating Types" |
...
...