Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Many command interpreters and parsers provide their own sanitization and validation methods. When available, their use is preferred over custom sanitization techniques because custom-developed sanitization can often neglect special cases or hidden complexities in the parser. Another problem with custom sanitization code is that it may not be adequately maintained when new capabilities are added to the command interpreter or parser software.

...

This noncompliant code example demonstrates a an XSS exploit. This code uses the CGI library module to display a web form , and is adopted from an example from the CGI.pm documentation The . The form queries the user for a name , and displays the resulting name on the page when the user clicks Submit.

...

But this code will happily parse image tags, HTML markup, JavascriptJavaScript, or any other commands an attacker may wish to send. The following picture demonstrates a remote image being loaded into the page on the request of the attacker:

Image RemovedImage Added

In this case. the trust boundary exists between the untrusted data and the CGI script, whereas the trusted domain is the web browser; or browser—or rather the HTML parsing and rendering engine within the web browser.

More details about sanitization of this code example can be found in IDS01-PL. Use taint mode while being aware of its limitations.

Noncompliant Code Example (Taint Mode)

Using Taint taint mode will not detect or prevent XSS. Taint mode does not prevent tainted data from being printed to standard output.

...

To prevent injection of HTML, JavascriptJavaScript, or malicious images, any untrusted input must be sanitized. This compliant solution sanitizes the input using the escapeHTML() subroutine from the CGI library.

...

When fed the malicious image tag demonstrated abovepreviously, the escapeHTML() subroutine sanitizes characters that might be misinterpreted by a web browser, causing the name to appear exactly as it was entered:

...

Suppose a database contains user names and passwords used to authenticate users of the system. An A SQL command to authenticate a user might take the form:

...

However, if an attacker can substitute arbitrary strings for <USERID> and <PASSWORD>, they he can perform a SQL injection by using the following string for <USERID>:

Code Block
validuser' OR '1'='1

When injected into the command, the command becomes:

Code Block
SELECT * FROM Users WHERE userid='validuser' OR '1'='1' AND password=<PASSWORD>

If validuser is a valid user name, this SELECT statement selects the validuser record in the table. The password is never checked because userid='validuser' is true; consequently, the items after the OR are not tested. As long as the components after the OR generate a syntactically correct SQL expression, the attacker is granted the access of validuser.

Likewise, an attacker could supply a string for <PASSWORD> such as:

Code Block
' OR '1'='1

...

Code Block
SELECT * FROM Users WHERE userid='' AND password='' OR '1'='1'

This time, the '1'='1' tautology disables both user ID and password validation, and the attacker is falsely logged in without a correct login ID or password.

...

One way to find potential injection points quickly is to use Perl's taint mode.

Code Block
bgColor#ffcccc#ccccff
langperl
# ... beginning of code 

my $dbh = DBI->connect("dbi:SQLite:dbname=$dbfile","","")
  or die "Couldn't connect to database: " . DBI->errstr;
$dbh->{TaintIn} = 1;

# ... rest of ocde

Perl will refuse to permit tainted data from entering the database via the prepare() method call. It will immediately exit with an error message:

Code Block
Insecure dependency in parameter 1 of DBI::db=HASH(0x17e4100)->prepare method call while running with -T switch at pl.pl line 29, <STDIN> line 2.

Note that not only must the program be run in taint mode, but the TaintIn attribute must be set on the connection handle, enabling taint checks to be run on the database.

Compliant Solution (

...

Prepared Statement)

Fortunately, Perl's DBI library provides an API for building SQL commands that sanitize untrusted data. The prepare() method properly escapes input strings, preventing SQL injection when used properly. This is an example of component-based sanitization.

...

Recommendation

Severity

Likelihood

Remediation Cost

Priority

Level

IDS33-PL

highHigh

likelyLikely

highHigh

P9

L2

Automated Detection

Tool

Diagnostic

Notes

Taint Modemode

Insecure dependency in parameter \d* of DBI::db=.* method call

Catches SQL injection.
Requires TaintIn attribute.

Related Guidelines

Bibliography

[

...

[CPAN] Bunce, Tim. DBI

...

Birznieks 1998]Birznieks, Gunther, CGI/Perl Taint Mode FAQ, Version 1.0, June 3, 1998
[CGI 2005]CGI.pm: A Perl5 CGI Library, Function-Oriented vs Object-Oriented Use
[CPAN]Bunce, Tim, DBI
[CPAN]Stosberg, Mark, CGI
[Lester 2006]Lester, Andy, "Perl's taint mode to the rescue," O'Reilly OULamp.com, November 17, 2006
[VU#246409]Input validation error in quikstore.cgi allows attackers to execute commands

...

 "

...

Image Modified Image Modified Image Modified