Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Declaring a shared variable volatile guarantees visibility in a thread-safe manner only when both of the following conditions are met:

The first condition can be relaxed when you can be sure that only one thread will ever update the value of the variable [Goetz 2006]. However, code that relies on a single-thread confinement is error prone and difficult to maintain. This design approach is permitted under this rule but is discouraged.

Synchronizing the code makes it easier to reason about its behavior and is frequently more secure than simply using the volatile keyword. However, synchronization has somewhat higher performance overhead and can result in thread contention and deadlocks when used excessively.

Declaring a variable volatile or correctly synchronizing the code both guarantee guarantees that 64-bit primitive long and double variables are accessed atomically. For more information on sharing those variables among multiple threads, see rule VNA05-J. Ensure atomicity when reading and writing 64-bit values.

...

This noncompliant code example uses a shutdown() method to set the non-volatile nonvolatile done flag that is checked in the run() method.:

Code Block
bgColor#FFcccc
final class ControlledStop implements Runnable {
  private boolean done = false;
 
  @Override public void run() {
    while (!done) {
      try {
        // ...
        Thread.currentThread().sleep(1000); // Do something
      } catch(InterruptedException ie) { 
        Thread.currentThread().interrupt(); // Reset interrupted status
      } 
    } 	 
  }

  public void shutdown() {
    done = true;
  }
}

If one thread invokes the shutdown() method to set the flag, a second thread might not observe that change. Consequently, the second thread might observe that done is still false and incorrectly invoke the sleep() method. Compilers and just-in-time compilers (JITs) are allowed to optimize the code when they determine that the value of done is never modified by the same thread, resulting in an infinite loop.

...

In this compliant solution, the done flag is declared volatile to ensure that writes are visible to other threads.:

Code Block
bgColor#ccccff
final class ControlledStop implements Runnable {
  private volatile boolean done = false;
 
  @Override public void run() {
    while (!done) {
      try {
        // ...
        Thread.currentThread().sleep(1000); // Do something
      } catch(InterruptedException ie) { 
        Thread.currentThread().interrupt(); // Reset interrupted status
      } 
    } 	 
  }

  public void shutdown() {
    done = true;
  }
}

...

This compliant solution uses the intrinsic lock of the Class object to ensure that updates are visible to other threads.:

Code Block
bgColor#ccccff
final class ControlledStop implements Runnable {
  private boolean done = false;
 
  @Override public void run() {
    while (!isDone()) {
      try {
        // ...
        Thread.currentThread().sleep(1000); // Do something
      } catch(InterruptedException ie) { 
        Thread.currentThread().interrupt(); // Reset interrupted status
      } 
    } 	 
  }

  public synchronized boolean isDone() {
    return done;
  }

  public synchronized void shutdown() {
    done = true;
  }
}

While Although this compliant solution is an acceptable compliant solution, intrinsic locks cause threads to block and may introduce contention. On the other hand, volatile-qualified shared variables do not block. Excessive synchronization can also make the program prone to deadlock.

Synchronization is a more secure alternative in situations where the volatile keyword or a java.util.concurrent.atomic.Atomic* field is inappropriate, such as when a variable's new value depends on its current value . See rule (see VNA02-J. Ensure that compound operations on shared variables are atomic for more information).

Compliance with rule LCK00-J. Use private final lock objects to synchronize classes that may interact with untrusted code can reduce the likelihood of misuse by ensuring that untrusted callers cannot access the lock object.

Exceptions

VNA00-J-EX0: Class objects are created by the virtual machine; their initialization always precedes any subsequent use. Consequently, cross-thread visibility of Class objects is already assured by default.

Risk Assessment

Failing to ensure the visibility of a shared primitive variable may result in a thread observing a stale value of the variable.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

VNA00-J

Medium

Probable

Medium

P8

L2

Automated Detection

Some static analysis tools are capable of detecting violations of this rule.

ToolVersionCheckerDescription
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

JAVA.CONCURRENCY.LOCK.ICS
JAVA.CONCURRENCY.SYNC.MSS
JAVA.CONCURRENCY.LOCK.STATIC
JAVA.CONCURRENCY.UG.FIELD
JAVA.CONCURRENCY.UG.PARAM
JAVA.CONCURRENCY.VOLATILE

Impossible Client Side Locking (Java)
Missing synchronized Statement (Java)
Synchronization on static (Java)
Unguarded Field (Java)
Unguarded Parameter (Java)
Useless volatile Modifier (Java)

Eclipse4
 ToolVersion Description  Eclipse 4
.2.0
 Not

Not Implemented
 FindBugs
FindBugs
 2
2.0.1
  Not Implemented PMD 5

Not Implemented
Parasoft Jtest
Include Page
Parasoft_V
Parasoft_V
CERT.VNA00.LORD
CERT.VNA00.MRAV
Ensure that nested locks are ordered correctly
Access related Atomic variables in a synchronized block
PMD5.0.0
  Not Implemented Fortify   Not Implemented Coverity  Fully

Not Implemented
Fortify

Not Implemented
Coverity7.5SERVLET_ATOMICITYImplemented
ThreadSafe
Include Page
ThreadSafe_V
ThreadSafe_V

CCE_SL_INCONSISTENT
CCE_CC_CALLBACK_ACCESS
CCE_SL_MIXED
CCE_SL_INCONSISTENT_COL
CCE_SL_MIXED_COL
CCE_CC_UNSAFE_CONTENT
CCE_FF_VOLATILE

Implemented

Related Guidelines

MITRE

CWE

CWE

-667. Improper locking 

CWE-413

.

, Improper

resource locking

Resource Locking

 

CWE-567

.

, Unsynchronized

access

Access to

shared data

Shared Data in a

multithreaded context

Multithreaded Context
CWE-667, Improper Locking

Bibliography

[Bloch 2008]

Item 66

.

, "Synchronize

access to shared mutable data

Access to Shared Mutable Data"

[Goetz 2006]

Section 3.4.2, "Example: Using Volatile to Publish Immutable Objects"

[JLS

2005

2015]

Chapter 17, "Threads and Locks

  

"
§17.4.

5, Happens-Before Order

3, "Programs and Program Order"


§17.4.

3, Programs and Program Order 

5, "Happens-before Order"
§17.4.8, "Executions and Causality Requirements"

[JPL 2006]

Section 14.10.3, "The Happens-Before Relationship

 

"


...

Image Added Image Added 07. Visibility and Atomicity (VNA)      07. Visibility and Atomicity (VNA)