...
A developer has the freedom to customize their SSL implementation, and thus has a responsibility to properly use SSL depending on . The developer should properly use SSL as appropriate to the intent of the app as well as app and the environment the apps are used in. If the SSL is not correctly used, a user's sensitive data may leak via the vulnerable SSL communication channel.
Fahl et al [Fahl 2012] summarises describes the following patterns of the insecure use of SSL:
- Trusting All Certificates
...
- : The developer implements the TrustManager interface so that it will trust all the server certificate (regardless of who signed it, what is the CN etc.)
- Allowing All Hostnames
...
- : The app does not verify if the certificate is issued for the URL the client is connecting to.
...
- For example, when a client connects to
example.com, it will accept a server certificate issued forsome-other-domain.com. - Mixed-Mode/No SSL
...
- : A developer mixes secure and insecure connections in the same app or does not use SSL at all.
On Android, using HttpURLConnection is recommended for HTTP client implementation.
Noncompliant Code Example
The following code implements a custom MySSLSocketFactory class that inherits javax.net.ssl.SSLContext:
| Code Block | ||
|---|---|---|
| ||
public class extends SSLSocketFactory {
SSLContext sslContext;
public MySSLSocketFactory (KeyStore truststore) throws NoSuchAlgorithmException, KeyManagementException,
KeyStoreException, UnrecoverableKeyException
{
super(truststore);
this.sslContext = SSLContext.getInstance("TLS");
this.sslContext.init (null, new TrustManager[] {new X509TrustManager() {
public void checkClientTrusted(X509Certificate[] chain, String authType) throws CertificateException
{
}
public void checkServerTrusted(X509Certificate[] chain, String authType) throws CertificateException
{
}
public X509Certificate[] getAcceptedIssuers() {
return null;
}
}}, null);
}
public Socket createSocket() throws IOException {
return this.sslContext.getSocketFactory().createSocket();
}
public Socket createSocket(Socket socket, String host, int port, boolean autoClose) throws IOException
, UnknownHostException {
return this.sslContext.getSocketFactory().createSocket(socket, host, port, autoClose);
}
}
<tt>checkClientTrusted()</tt> and <tt>checkServerTrusted()</tt> are overriden to make a blank implementation so that
<tt>SSLSocketFactory</tt> does not verify SSL certificate. <tt>MySSLSocketFactory</tt> class is used to create an instance of
<tt>HttpClient</tt> in other part of the application:
public }
public static HttpClient getNewHttpClient() {
DefaultHttpClient v6;
try {
KeyStore v5 = KeyStore.getInstance(KeyStore.getDefaultType());
v5.load(null, null);
MySSLSocketFactory mySSLScoket = new MySSLSocketFactory(v5);
if(DefineRelease.sAllowAllSSL) {
((SSLSocketFactory)mySSLScoket).setHostnameVerifier(SSLSocketFactory.ALLOW_ALL_HOSTNAME_VERIFIER);
}
BasicHttpParams v2 = new BasicHttpParams();
HttpConnectionParams.setConnectionTimeout(((HttpParams)v2), 30000);
HttpConnectionParams.setSoTimeout(((HttpParams)v2), 30000);
HttpProtocolParams.setVersion(((HttpParams)v2), HttpVersion.HTTP_1_1);
HttpProtocolParams.setContentCharset(((HttpParams)v2), "UTF-8");
SchemeRegistry v3 = new SchemeRegistry();
v3.register(new Scheme("http", PlainSocketFactory.getSocketFactory(), 80));
v3.register(new Scheme("https", ((SocketFactory)mySSLScoket), 443));
v6 = new DefaultHttpClient(new ThreadSafeClientConnManager(((HttpParams)v2), v3), ((HttpParams)v2));
}
catch(Exception v1) {
v6 = new DefaultHttpClient();
}
return ((HttpClient)v6);
}
|
Proof of Concept
Typically, an application stores files in the directory as follows:
| Code Block |
|---|
/sdcard/Android/data/com.company.app/files/save/appdata/save_appdata
|
Compliant Solution (Save a File on Internal Storage)
The following code uses the openFileOutput() method to create "myfile" in an application data directory with permission set to MODE_PRIVATE so that other apps cannot access the file:
In the example above, checkClientTrusted()and checkServerTrusted() are overriden to make a blank implementation so that SSLSocketFactory does not verify the SSL certificate. The MySSLSocketFactory class is used to create an instance of HttpClient in another part of the application.
sAllowAllSSL, which is a static member of the DefineRelease class, is initialized to true in its static constructor. This will enable the use of SSLSocketFactory.ALLOW_ALL_HOSTNAME_VERIFIER. As a result, host name verification that should take place when establishing an SSL connection is disabled and will lead to the same situation as all the certificate is trusted.
Compliant Solution
The compliant solution may vary, depending on the actual implementation. For examples of secure implementation such as using a self-signed server certificate, please refer to "Android Application Secure Design/Secure Coding Guidebook", Section 5.4 Communicate by HTTPS.
Risk Assessment
Not properly verifying the server certificate on SSL/TLS may allow apps to connect to an imposter site, while fooling the user into thinking that the user is connected to an intended site. One example of associated risks is that this could expose a user's sensitive data
| Code Block | ||
|---|---|---|
| ||
private String filename = "myfile"
private String string = "sensitive data such as credit card number"
FileOutputStream fos = null;
try {
fos = openFileOutput(filename, Context.MODE_PRIVATE);
fos.write(string.getBytes());
fos.close();
} catch (FileNotFoundException e) {
// handle FileNotFoundException
} catch (IOException e) {
// handle IOException
} finally {
if (fos != null) {
try {
fos.close();
} catch (IOException e) {
}
}
}
|
Risk Assessment
Storing sensitive information on external storage can leak sensitive information to malicious apps.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
|---|---|---|---|---|---|
DRD00DRD19-J | highHigh | probableProbable | mediumMedium | P12 | L1 |
Automated Detection
It is possible to automatically detect whether an application writes to external storage. It uses one of the three Android SDK packages named for establishing network connections, and to check if any of the methods from those classes are overriden by the application. It is not feasible to automatically determine whether such output could be stored internallythe intent of the app or the environment the apps are used in.
Related Vulnerabilities
- VU#582497 Multiple Android applications fail to properly validate SSL certificates
- JVN#39218538 Pizza Hut Japan Official Order App for Android has a problem whereby it fails to verify SSL server certificates.
- JVN#75084836 Yome Collection for Android has a problem with management of IMEI.
- JVN#68156832 Yafuoku! contains an issue where it fails to verify SSL server certificates.
- JVN#92038939 mixi for Android information management vulnerability
- JVN#05102851 Yome Collection for Android issue in management of IMEI
Related Guidelines
45.6 Secure File Handling |
Bibliography
| [Android API 2013] | Class Environment |
| [JSSEC 2013] | 4.6 Secure File Handling |
4 Communicating via HTTPS |
...