Page History

...

Assertions should never be used to verify the absence of runtime (as opposed to logic) errors, such as

• invalid Invalid user input (including command-line arguments and environment variables)
• file File errors (for example, errors opening, reading or writing files)
• network Network errors (including network protocol errors)
• outOut-of-memory conditions (for example, malloc() or similar failures)
• system System resource exhaustion (for example, out-of-file descriptors, processes, threads)
• system System call errors (for example, errors executing files, locking or unlocking mutexes)
• invalid Invalid permissions (for example, file, memory, user)

...

This noncompliant code example uses the assert() macro to verify that memory allocation succeeded. Because memory availability depends on the overall state of the system and can become exhausted at any point during a process lifetime, a robust program must be prepared to gracefully handle and recover from its exhaustion. Consequently, using the assert() macro to verify that a memory allocation succeeded would be inappropriate because doing so might lead to an abrupt termination of the process, opening the possibility of a denial-of-service attack. See also MEM11-C. Do not assume infinite heap space and void MEM32-C. Detect and handle memory allocation errors.

char *dupstring(const char *c_str) {
  size_t len;
  char *dup;

  len = strlen(c_str);
  dup = (char *)malloc(len + 1);
  assert(NULL != dup);

  memcpy(dup, c_str, len + 1);
  return dup;
}

...

This compliant solution demonstrates how to detect and handle possible memory exhaustion.:

char *dupstring(const char *c_str) {
  size_t len;
  char *dup;

  len = strlen(c_str);
  dup = (char*)malloc(len + 1);
  /* detectDetect and handle memory allocation error */
  if (NULL == dup) {
      return NULL; 
  }

  memcpy(dup, c_str, len + 1);
  return dup;
}

...

Assertions are a valuable diagnostic tool for finding and eliminating software defects that may result in vulnerabilities. The absence of assertions, however, does not mean that code is incorrect.

Automated Detection

Related Vulnerabilities

Search for for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

...

...

Image Modified Image Modified Image Modified