Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Updated references from C11->C23
Warning
titleWarning

This section is under construction.

The formatted IO functions fprintf(), printf(), sprintf(), snprintf(), vfprintf(), vprintf(), vsprintf(), and vsnprintf(The formatted output functions (fprintf() and related functions) convert, format, and print their arguments under control of a format string.  Section The C Standard, 7.2123.6.1 of the C standard , paragraph 3 [ISO/IEC 9899:20112024], states:specifies

The format shall be a multibyte character sequence, beginning and ending in its initial shift state. The format is composed of zero or more directives: ordinary multibyte characters (not %), which are copied unchanged to the output stream; and conversion specifications, each of which results in fetching zero or more subsequent arguments, converting them, if applicable, according to the corresponding conversion specifier, and then writing the result to the output stream.

...

  • Zero or more flags (in any order), which modify the meaning of the conversion specification
  • An optional minimum field width
  • An optional precision that gives the minimum number of digits to appear for certain conversion specifiers, the maximum number of digits, or the maximum number of bytes, etc. depending on the conversion specifier
  • An optional length modifier that specifies the size of the argument
  • A conversion specifier character that indicates the type of conversion to be applied

Common mistakes in creating format strings include

  • providing insufficient Providing an incorrect number of arguments for the format string
  • using Using invalid conversion specifiers
  • using Using a flag character that is incompatible with the conversion specifier
  • using Using a length modifier that is incompatible with the conversion specifier
  • mismatching Mismatching the argument type and conversion specifier
  • using Using an argument of type other than int for width or precision

The following table summarizes C-compliant conversion specifiers along with the flag characters valid for each specification (the apostrophe (')the compliance of various conversion specifications. The first column contains one or more conversion specifier characters. The next four columns consider the combination of the specifier characters with the various flags (the apostrophe ['], -, +, the space character, #, and # in columns 2 through 5) and 0). The next eight columns consider the combination of the specifier characters with the various length modifiers (h, hh, l, ll, j, z, t, and L in columns 6 through 13) and the type of the expected argument.

Valid and meaningful combinations are marked with a type name; arguments matched with the conversion specification are interpreted as that type. For example, an argument matched with the specifier %hd is interpreted as a short, so short appears in the cell where d and h intersect. The last column denotes the expected types of arguments matched with the original specifier characters.

Valid and meaningful combinations are marked by the (tick) symbol (save for the length modifier columns, as described previously) of a conversion specification, flag character, and length modifier is denoted by the (tick) symbol in the corresponding cell or by the name of the type argument affected by the length modifier. Valid combinations that have no effect are denoted by labeled N/E. Using a combination of a conversion specification, flag character, and length modifier denoted marked by the (error) symbol or a , using a specification not listed represented in the table, or using an argument of argument of an unexpected type , may result in is undefined behavior. (See undefined behaviors 153, 155, 157, 158, 161, and 162 in Annex J of C11.

Conversion
Specifier
Character

' XSI

-
+
SPACE


#


0

 


h


hh


l


ll


j


z


t


L

Argument
Type

d, i

(tick)

(tick)

(error)

(tick)

 

short

signed char

long

long long

intmax_t

size_t

ptrdiff_t

(error)

signed

Signed integer

o

(error)

(tick)

(tick)

(tick)

 

unsigned short

unsigned char

unsigned long

unsigned long long

intmax

uintmax_t

size_t

ptrdiff_t

(error)

unsigned

Unsigned integer

u

(tick)

(tick)

(error)

(tick)

 

unsigned short

char

long

long long

intmax_t

size_t

ptrdiff_t

(error)

unsigned

integer

x

(error)

(tick)

(tick)

(tick)

 

short

char

unsigned long

unsigned long long

intmax

uintmax_t

size_t

ptrdiff_t

(error)

unsigned

Unsigned integer

x, X

(error)

(tick)

(tick)

(tick)

 

unsigned short

unsigned char

unsigned long

unsigned long long

intmax

uintmax_t

size_t

ptrdiff_t

(error)

unsigned

Unsigned integer

f, F

(tick)

(tick)

(tick)

(tick)

 

(error)

(error)

N/E

N/E

(error)

(error)

(error)

long double

double or long double

e, E

(error)

(tick)

(tick)

(tick)

 

(error)

(error)

N/E

N/E

(error)

(error)

(error)

long double

double or long double

g, G

(tick)

(tick)

(tick)

(tick)

 

(error)

(error)

N/E

N/E

(error)

(error)

(error)

long double

double or long double

a, A

(tick)

(tick)

(tick)

(tick)

 

(error)

(error)

N/E

N/E

(error)

(error)

(error)

long double

double or long double

c

(error)

(tick)

(error)

(error)

 

(error)

(error)

wint_t

(error)

(error)

(error)

(error)

(error)

int or wint_t

s

(error)

(tick)

(error)

(error)

 

(error)

(error)

NTWS

(error)

(error)

(error)

(error)

(error)

NTBS or NTWS

p

(error)

(tick)

(error)

(error)

 

(error)

(error)

(error)

(error)

(error)

(error)

(error)

(error)

void*

n

(error)

(tick)

(error)

(error)

(error)

 

short*

char*

long*

long long*

intmax_t*

size_t*

ptrdiff_t*

(error)

pointer

Pointer to integer

C XSI

(error)

(tick)

(error)

(error)

 

(error)

(error)

(error)

(error)

(error)

(error)

(error)

(error)

wint_t

S XSI

(error)

(tick)

(error)

(error)

 

(error)

(error)

(error)

(error)

(error)

(error)

(error)

(error)

NTWS

%

(error)

(tick)

(error)

(error)

(error)

 

(error)

(error)

(error)

(error)

(error)

(error)

(error)

(error)

none

None

Legend     SPACE:

...

The space (

...

" ") character
     N/E

...

: No effect
     NTBS: char* argument pointing to a null-terminated

...

character string

...

     NTWS: wchar_t* argument pointing to a null-terminated wide

...

character string

...

     XSI: ISO/IEC 9945-2003 XSI extension

The formatted input functions (fscanf() and related functions) use similarly specified format strings and impose similar restrictions on their format strings and arguments.

Do not supply an unknown or invalid conversion specification or an invalid combination of flag character, precision, length modifier, or conversion specifier to a formatted IO function. Likewise, do not provide a number or type of argument that does not match the argument type of the conversion specifier used in the format string.

Format strings are usually string literals specified at the call site, but they need not be. However, they should not contain tainted values. (See FIO30-C. Exclude user input from format strings for more information.)

Noncompliant Code Example

Mismatches between arguments and conversion specifications may result in undefined behavior. Many compilers can Compilers may diagnose type mismatches in formatted output function invocations. In this noncompliant code example, the error_type argument to printf() is incorrectly matched with the s specifier rather than with the d specifier. Likewise, the error_msg argument is incorrectly matched with the d specifier instead of the s specifier. These usages result in undefined behavior. One possible result of this invocation is that printf() will interpret the error_type argument as a pointer and try to read a string from the address that error_type contains, possibly resulting in an access violation.

Code Block
bgColor#ffcccc
langc
#include <stdio.h>
 
void func(void) {
  const char *error_msg = "Resource not available to user.";
  int error_type = 3;
  /* ... */
  printf("Error (type %s): %d\n", error_type, error_msg);
  /* ... */
}

Compliant Solution

This compliant solution ensures that the format arguments to the printf() function match their respective format conversion specifications.:

Code Block
bgColor#ccccff
langc
#include <stdio.h>
 
void func(void) {
  const char *error_msg = "Resource not available to user.";
  int error_type = 3;
  /* ... */
  printf("Error (type %d): %s\n", error_type, error_msg);

Noncompliant Code Example

The width and precision arguments to printf() format directives must be of type int. Section 7.21.6.1 of the C standard [ISO/IEC 9899:2011], states:

A field width, or precision, or both, may be indicated by an asterisk ('*'). In this case, an argument of type int supplies the field width or precision.

Passing them as any other type leads to undefined behavior. In this noncompliant code example, the width and precision are specified using parameters declared to be of size_t type. These are unsigned types that may not be the same size as int.

Code Block
bgColor#ffcccc
langc
int print_int(int i, size_t width, size_t prec) {
  int n;

  n = printf("%*.*d", width, prec, i);

  return n;
}

Compliant Solution

In this compliant solution, the field width and precision arguments to printf() format directives are of type int.

Code Block
bgColor#ccccff
langc
int print_int(int i, int width, int prec) {
  int n;

  n = printf("%*.*d", width, prec, i);

  return n;
}

Risk Assessment

/* ... */
}

Risk Assessment

Incorrectly specified format strings can result in memory corruption or In most cases, incorrectly specified format strings will result in abnormal program termination.

Recommendation

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

FIO00

FIO47-C

high

High

unlikely

Unlikely

medium

Medium

P6

L2

Automated Detection

Tool

Version

Checker

Description

LDRA tool suite
Axivion Bauhaus Suite

Include Page

LDRA

Axivion Bauhaus Suite_V

LDRA

Axivion Bauhaus Suite_V

486 S
589 S

Fully implemented.
CertC-FIO47Fully implemented
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

IO.INJ.FMT
MISC.FMT
MISC.FMTTYPE

Format string injection
Format string
Format string type error

Coverity
Include Page
Coverity_V
Coverity_V
PWReports when the number of arguments differs from the number of required arguments according to the format string
GCC
Include Page
GCC_V
GCC_V

 


Can detect violations of this recommendation when the -Wformat flag is used

.

Helix QAC

Include Page
Helix QAC_V
Helix QAC_V

C0161, C0162, C0163, C0164, C0165, C0166, C0167, C0168, C0169, C0170, C0171, C0172, C0173, C0174, C0175, C0176, C0177, C0178, C0179, C0180, C0184, C0185, C0190, C0191, C0192, C0193, C0194, C0195, C0196, C0197, C0198, C0199, C0200, C0201, C0202, C0204, C0206, C0209

C++3150, C++3151, C++3152, C++3153, C++3154, C++3155, C++3156, C++3157, C++3158, C++3159


Klocwork
Include Page
Klocwork_V
Klocwork_V

SV.FMT_STR.PRINT_FORMAT_MISMATCH.BAD
SV.FMT_STR.PRINT_FORMAT_MISMATCH.UNDESIRED
SV.FMT_STR.

 

PRINT_IMPROP_LENGTH
SV.FMT_STR.PRINT_PARAMS_WRONGNUM.FEW
SV.FMT_STR.PRINT_PARAMS_WRONGNUM.MANY
SV.FMT_STR.SCAN_FORMAT_MISMATCH.BAD
SV.FMT_STR.SCAN_FORMAT_MISMATCH.UNDESIRED
SV.FMT_STR.SCAN_IMPROP_LENGTH
SV.FMT_STR.SCAN_PARAMS_WRONGNUM.FEW
SV.FMT_STR.SCAN_PARAMS_WRONGNUM.MANY
SV.FMT_STR.UNKWN_FORMAT


LDRA tool suite
Include Page
LDRA_V
LDRA_V

486 S
589 S

Fully implemented

Parasoft C/C++test
Include Page
Parasoft_V
Parasoft_V

CERT_C-FIO47-a
CERT_C-FIO47-b
CERT_C-FIO47-c
CERT_C-FIO47-d
CERT_C-FIO47-e
CERT_C-FIO47-f

There should be no mismatch between the '%s' and '%c' format specifiers in the format string and their corresponding arguments in the invocation of a string formatting function
There should be no mismatch between the '%f' format specifier in the format string and its corresponding argument in the invocation of a string formatting function
There should be no mismatch between the '%i' and '%d' format specifiers in the string and their corresponding arguments in the invocation of a string formatting function
There should be no mismatch between the '%u' format specifier in the format string and its corresponding argument in the invocation of a string formatting function
There should be no mismatch between the '%p' format specifier in the format string and its corresponding argument in the invocation of a string formatting function
The number of format specifiers in the format string and the number of corresponding arguments in the invocation of a string formatting function should be equal

PC-lint Plus

Include Page
PC-lint Plus_V
PC-lint Plus_V

492, 493, 494, 499, 557,
558, 559, 566, 705, 706,
719, 816, 855, 2401, 2402,
2403, 2404, 2405, 2406, 2407

Fully supported

Polyspace Bug Finder

Include Page
Polyspace Bug Finder_V
Polyspace Bug Finder_V

CERT C: Rule FIO47-C

Check for format string specifiers and arguments mismatch (rule fully covered)

PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V510, V576
TrustInSoft Analyzer

Include Page
TrustInSoft Analyzer_V
TrustInSoft Analyzer_V

match format and argumentsExhaustively verified (see the compliant and the non-compliant example).

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

...

Key here (explains table format and definitions)

...

Prior to 2018-01-12: CERT: Unspecified Relationship
ISO/IEC

...

TS 17961:2013Using invalid format strings [invfmtstr]

...

Prior to 2018-01-12: CERT: Unspecified Relationship
CWE 2.11CWE-686,

...

Function Call

...

with Incorrect Argument Type2017-06-29: CERT: Partial overlap
CWE 2.11CWE-6852017-06-29: CERT: Partial overlap

CERT-CWE Mapping Notes

Key here for mapping notes

CWE-686 and FIO47-C

Intersection( EXP37-C, FIO47-C) =


  • Invalid argument types passed to format I/O function


EXP37-C – FIO47-C =


  • Invalid argument types passed to non-format I/O function


FIO47-C – EXP37-C =


  • Invalid format string, but correctly matches arguments in number and type


Intersection( CWE-686, FIO47-C) =


  • Use of format strings that do not match the type of arguments


CWE-686 – FIO47-C =


  • Incorrect argument type in functions outside of the printf() family.


FIO47-C – CWE-686 =


  • Invalid format strings that still match their arguments in type


CWE-685 and FIO47-C

Intersection( CWE-685, FIO47-C) =


  • Use of format strings that do not match the number of arguments


CWE-685 – FIO47-C =


  • Incorrect argument number in functions outside of the printf() family.


FIO47-C – CWE-685 =


  • Invalid format strings that still match their arguments in number


CWE-134 and FIO47-C

Intersection( FIO30-C, FIO47-C) =


  • Use of untrusted and ill-specified format string


FIO30-C – FIO47-C =


  • Use of untrusted, but well-defined format string


FIO47-C – FIO30-C =


  • Use of Ill-defined, but trusted format string


FIO47-C = Union(CWE-134, list) where list =


  • Using a trusted but invalid format string


Bibliography

[ISO/IEC 9899:2024]Subclause 7.23.6.1, "The fprintf Function"

...


...

Image Modified Image Modified Image Modified