Logging is essential for debugging, incident response, or and collecting forensic evidence. Nevertheless, logging sensitive data raises many concerns, including the privacy of the stakeholders, limitations imposed by the law on the collection of personal information, and the potential for data exposure by insiders. Sensitive information includes, but is not limited to, IP addresses, user names and passwords, email addresses, credit card numbers, and any personally identifiable information such as social security numbers. Many countries prohibit or restrict collection of personal data; others permit retention of personal data only when held in an anonymized form. For example, leaking unencrypted credit card numbers into a log file could be a violation of PCI DSS (Payment Card Industry Data Security Standard) regulations [PCI 2010]. Consequently, logs must not contain sensitive data, particularly when prohibited by law.
Unfortunately, violations of this rule are common. For example, prior to version 0.8.1, the LineControl Java client logged sensitive information, including the local user's password, as documented by CVE-2005-2990.
The java.util.logging
class provides a basic logging framework for JDK versions 1.4 and higher. Other logging frameworks exist, however, but the basic principles apply regardless of the particular logging framework chosen.
Programs must typically support varying levels of protection. Some information, such as access times, can be safely logged. Some information can be logged, but the log file must be restricted from everyone but particular administrators. Other information, such as credit card numbers, can be included in logs only be logged in encrypted form. Other information, Information such as passwords , should not be logged at all.
For these the following code samplesexamples, we will assume that the log in question lies outside the trust boundary of the information being sent to itrecorded. Also, normal log messages should include additional parameters such as date, time, source event, and so forth. This information has been omitted from our the following code examples for the brevity.
Noncompliant Code Example
In this noncompliant code example, a server logs the IP address of the remote client in the event of a security exception. This data can be misused, for example, to build a profile of a user's browsing habits. Such logging may violate legal restrictions in many countries.
If When the log cannot contain IP addresses, it should not contain any information about a SecurityException
, because it might leak an IP address. When an exception contains sensitive information, the custom MyExceptionReporter
class should extract or cleanse it , before returning control to the next statement in the catch
block (see rule ERR00-J. Do not suppress or ignore checked exceptions).
Code Block | ||
---|---|---|
| ||
public void logRemoteIPAddress(String name) { Logger logger = Logger.getLogger("com.organization.Log"); InetAddress machine = null; try { machine = InetAddress.getByName(name); } catch (UnknownHostException e) { Exception e = MyExceptionReporter.handle(e); } catch (SecurityException e) { Exception e = MyExceptionReporter.handle(e); logger.severe(name + "," + machine.getHostAddress() + "," + e.toString()); } } |
Compliant Solution
This compliant solution does not log security exceptions .except for the logging implicitly performed by MyExceptionReporter
:
Code Block | ||
---|---|---|
| ||
// ...
catch (SecurityException e) {
Exception e = MyExceptionReporter.handle(e);
}
|
Noncompliant Code Example
Log messages with sensitive information should not be printed to the console display for security reasons (a possible example might be of sensitive information is passenger age). The java.util.logging.Logger
class supports different logging levels that can be used for classifying such information. These are : FINEST
, FINER
, FINE
, CONFIG
, INFO
, WARNING
, and SEVERE
. By default, the INFO
, WARNING
, and SEVERE
levels print the message to the console, which is accessible by end users and system administrators.
This noncompliant code example assumes that the log message is not so sensitive as appear in other destinations, such as system log files, but is too sensitive to appear on a console displayIf we assume that the passenger age can appear in log files on the current system but not on the console display, this code example is noncompliant.
Code Block | ||
---|---|---|
| ||
logger.info("Age: " + passengerAge);
|
Compliant Solution
This compliant solution logs the passenger age at a level below INFO
— FINEST
, in this case — to prevent the passenger age from being displayed the FINEST
level to prevent this information from displaying on the console. As noted previously, we are assuming the age may appear in system log files but not on the console.
Code Block | ||
---|---|---|
| ||
// makeMake sure that all handlers only print log messages rated INFO or higher Handler handlers[] = logger.getHandlers(); for (int i = 0; i < handlers.length; i++) { handlers[i].setLevel(Level.INFO); } // ... logger.finest("Age: " + passengerAge); |
Risk Assessment
Logging sensitive information can violate system security policies and can violate user privacy when the logging level is incorrect or when the log files are insecure.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|
FIO13-J |
Medium |
Probable |
High | P4 | L3 |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="f72b487d-eeb7-47fc-be91-c34af372bf93"><ac:plain-text-body><![CDATA[ | [[MITRE 2009 | AA. Bibliography#MITRE 09]] | [CWE ID 532 | http://cwe.mitre.org/data/definitions/532.html] "Information Exposure Through Log Files" | ]]></ac:plain-text-body></ac:structured-macro> |
| CWE ID 533 "Information Exposure Through Server Log Files" | ||||
| CWE ID 359 "Privacy Violation" | ||||
| CWE ID 542 "Information Exposure Through Cleanup Log Files" |
Bibliography
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Parasoft Jtest |
| CERT.FIO13.SENS CERT.FIO13.LHII CERT.FIO13.PEO CERT.FIO13.CONSEN | Prevent exposure of sensitive data Avoid logging sensitive Hibernate-related information at the 'info' level in 'log4j.properties' files Do not pass exception messages into output in order to prevent the application from leaking sensitive information Do not log confidential or sensitive information |
Related Guidelines
CWE-359, Privacy Violation |
Android Implementation Details
DRD04-J. Do not log sensitive information is an Android-specific instance of this rule.
Bibliography
[API 2014] |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="efaddf11-6364-4108-b197-fa39cee4f40a"><ac:plain-text-body><![CDATA[
[[API 2006
]]></ac:plain-text-body></ac:structured-macro>
] |
Section 11.1, "Privacy and Regulation: Handling Private Information |
]]></ac:plain-text-body></ac:structured-macro>
" |
[CVE |
2011] |
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-2990]
]]></ac:plain-text-body></ac:structured-macro>
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="177844c9-c4d8-41ac-a1ca-f20322558bac"><ac:plain-text-body><![CDATA[
[[Sun 2006
AA. Bibliography#Sun 06]]
[Java Logging Overview
http://java.sun.com/javase/6/docs/technotes/guides/logging/overview.html]
]]></ac:plain-text-body></ac:structured-macro>
Payment Card Industry (PCI) Data Security Standard | |
[Sun 2006] |
...
FIO07-J. Do not create temporary files in shared directories 12. Input Output (FIO) FIO09-J. Detect and handle file-related errors