...
A common practice is to use a macro in a preprocessor conditional which that guards against multiple inclusions of a header file. While this is a recommended practice, many programs use reserved names as the header guards. Such a name may clash with reserved names defined by the implementation of the C++ standard template library in its headers or with reserved names implicitly predefined by the compiler even when no C++ standard library header is included.
...
This compliant solution avoids using leading or trailing underscores in the name of the header guard:.
Code Block | ||||
---|---|---|---|---|
| ||||
#ifndef MY_HEADER_H #define MY_HEADER_H // Contents of <my_header.h> #endif // MY_HEADER_H |
...
In this noncompliant code example, a user-defined literal operator"" x is declared. However, literal suffix identifiers are required to start with an underscore; literal suffixes without the underscore prefix are reserved for future library implementations:.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <cstddef> unsigned int operator"" x(const char *, std::size_t); |
...
In this compliant solution, the user-defined literal is named operator"" _x
, which is not a reserved identifier:.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <cstddef> unsigned int operator"" _x(const char *, std::size_t); |
Note that the The name of the user-defined literal is operator"" _x
and not _x
, which would have otherwise been reserved for the global namespace.
...
In this compliant solution, file scope identifiers do not begin with an underscore:.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <cstddef> // for size_t static const std::size_t max_limit = 1024; std::size_t limit = 100; unsigned int get_value(unsigned int count) { return count < limit ? count : limit; } |
...
In this noncompliant code example, because the C++ standard template library header <cinttypes>
is specified to include <cstdint>
, as per [c.files] paragraph 4 [ISO/IEC 14882-2014], the name MAX_SIZE
conflicts with the name of the <cstdint>
header macro used to denote the upper limit of std:size_t
:.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <cinttypes> // for int_fast16_t void f(std::int_fast16_t val) { enum { MAX_SIZE = 80 }; // ... } |
...
This compliant solution avoids redefining reserved names:.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <cinttypes> // for std::int_fast16_t void f(std::int_fast16_t val) { enum { BufferSize = 80 }; // ... } |
...
DCL51-CPP-EX1: For compatibility with other compiler vendors or language standard modes, it is acceptable to create a macro identifier that is the same as a reserved identifier so long as the behavior is semantically identical, as in this example:.
Code Block | ||||
---|---|---|---|---|
| ||||
// Sometimes generated by configuration tools such as autoconf #define const const // Allowed compilers with semantically equivalent extension behavior #define inline __inline |
DCL51-CPP-EX2: As a compiler vendor or standard library developer, it is acceptable to use identifiers reserved for your implementation. Reserved identifiers may be defined by the compiler, in standard library headers, or in headers included by a standard library header, as in this example declaration from the libc++ STL implementation:.
Code Block | ||||
---|---|---|---|---|
| ||||
// The following declaration of a reserved identifier exists in the libc++ implementation of // std::basic_string as a public member. The original source code may be found at: // http://llvm.org/svn/llvm-project/libcxx/trunk/include/string template<class charT, class traits = char_traits<charT>, class Allocator = allocator<charT>> class basic_string { // ... bool __invariants() const; }; |
...
Using reserved identifiers can lead to incorrect program operation.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
DCL51-CPP | Low | Unlikely | Low | P3 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| reserved-identifier | Partially checked | ||||||
Axivion Bauhaus Suite |
| CertC++-DCL51 | |||||||
Clang |
| -Wreserved-id-macro -Wuser-defined-literals | The -Wreserved-id-macro flag is not enabled by default or with -Wall , but is enabled with -Weverything . This flag does notcatch all instances of this rule, such as redefining reserved names. | ||||||
CodeSonar |
| LANG.ID.NU.MK LANG.STRUCT.DECL.RESERVED | Macro name is C keyword Declaration of reserved name | ||||||
Helix QAC |
| C++5003 | |||||||
Klocwork |
| MISRA.DEFINE.WRONGNAME | |||||||
LDRA tool suite |
| 86 S, 218 S, 219 S, 580 S | Fully implemented | ||||||
Parasoft C/C++test |
| CERT_CPP-DCL51-a | Do not #define or #undef identifiers with names which start with underscore | |||||||
Polyspace Bug Finder |
| CERT C++: DCL51-CPP | Checks for redefinitions of reserved identifiers (rule partially covered) | ||||||
PVS-Studio |
| V1059 | |||||||
RuleChecker |
| reserved-identifier | Partially checked |
SonarQube C/C++ Plugin |
|
978 |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
SEI CERT C++ Coding Standard | DCL58-CPP. Do not modify the standard namespaces |
SEI CERT C Coding Standard | DCL37-C. Do not declare or define a reserved identifier PRE06-C. Enclose header files in an |
include guard | |
MISRA C++:2008 | Rule 17-0-1 |
Bibliography
[ISO/IEC 14882-2014] | Subclause 17.6.4.3, "Reserved Names" |
[ISO/IEC 9899:2011 ] | Subclause 7.1.3, "Reserved Identifiers" |
...
...