Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

According to the The Java Language Specification (JLS), �������‚�š�š�š§4 §4.2.3, "Floating-Point Types, Formats, and Values" [JLS 20052015]:

NaN (not-a-number) is unordered, so the numerical comparison operators <, <=, >, and >= return false if either or both operands are NaN. The equality operator == returns false if either operand is NaN, and the inequality operator != returns true if either operand is NaN.

Because this unordered property is often unexpected, direct comparisons with NaN must not be performed. Problems can arise when programmers write code that compares floating-point values without considering the semantics of NaN. For example, input validation checks that fail to consider the possibility of a NaN value as input can produce unexpected results . See rule (see NUM08-J. Check floating-point inputs for exceptional values for additional information).

Noncompliant Code Example

This noncompliant code example attempts a direct comparison with NaN. In accordance with the semantics of NaN, all comparisons with NaN yield false (with the exception of the != operator, which returns true). Consequently, this comparison always return false, and the "result is NaN" message is never printed.

Code Block
bgColor#FFcccc

public class NaNComparison {
  public static void main(String[] args) {
    double x = 0.0;
    double result = Math.cos(1/x); // returnsReturns NaN if input is infinity
    if (result == Double.NaN) { // comparisonComparison is always false!
      System.out.println("result is NaN");
    }
  }
}

...

This compliant solution uses the method Double.isNaN() to check whether the expression corresponds to a NaN value.:

Code Block
bgColor#ccccff

public class NaNComparison {
  public static void main(String[] args) {
    double x = 0.0;	  
    double result = Math.cos(1/x); // returnsReturns NaN when input is infinity
    if (Double.isNaN(result)) { 
      System.out.println("result is NaN");
    }
  }
}

...

Comparisons with NaN values can lead to unexpected results.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

NUM07-J

low

Low

probable

Probable

medium

Medium

P4

L3

Automated Detection

Automated detection of comparison with NaN is straightforward. Sound determination of whether the possibility of an unordered result has been correctly handled is not feasible in the general case. Heuristic checks could be useful.

ToolVersionCheckerDescription
Parasoft Jtest
Include Page
Parasoft_V
Parasoft_V
CERT.NUM07.NANAvoid comparisons to Double.NaN or Float.NaN
PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V6038

Bibliography


...

Image Added Image Added NUM06-J. Use the strictfp modifier for floating-point calculation consistency across platforms      03. Numeric Types and Operations (NUM)