Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Parasoft Jtest 2022.2

Wiki Markup Programmers frequently make errors regarding the precedence of operators because of the unintuitive unintuitively low - precedence levels of {{&}}, {{\|}}, {{\^}}, {{<<}}, and {{>>}}. Avoid mistakes regarding precedence through the suitable use of parentheses. This also improves code readability, unless taken to excess. The precedence of operations by the order of the subclauses are defined in the Java Tutorials \[[Tutorials 2008|AA. Bibliography#Tutorials 08]\parentheses, which also improves code readability. The precedence of operations by the order of the subclauses is defined in the Java Tutorials [Tutorials 2013].

Although it advises against depending on parentheses for specifying evaluation order , guideline "EXP08EXP05-J. Do not write more than once to the same variable follow a write by a subsequent write or read of the same object within an expression" applies only to expressions that contain side effects.

Noncompliant Code Example

The intent of the expression in this noncompliant code example is to add the variable OFFSET to the result of the bitwise logical AND between x and MASK.:

Code Block
bgColor#FFCCCC

public static final int MASK = 1337;
public static final int OFFSET = -1337;

public static int computeCode(int x) {
  return x & MASK + OFFSET;
}

According to the operator precedence guidelines, the expression is parsed as the following:

Code Block

x & (MASK + OFFSET)

This expression gets is evaluated , as shown belowfollows, resulting in the value 0.:

Code Block

x & (1337 - 1337)

Compliant Solution

This compliant solution uses parentheses to ensure that the expression evaluates is evaluated as intended.:

Code Block
bgColor#ccccff

public static final int MASK = 1337;
public static final int OFFSET = -1337;

public static int computeCode(int x) {
  return (x & MASK) + OFFSET;
}

Noncompliant Code Example

In this noncompliant code example, the intent is to append either "0" or "1" to the string "value=":

Code Block
bgColor#FFCCCC
public class PrintValue {
  public static void main(String[] args) {
    String s = null;
    // Prints "1"
    System.out.println("value=" + s == null ? 0 : 1);
  }

Exceptions

}

However, the precedence rules result in the expression to be printed being parsed as ("value=" + s) == null ? 0 : 1.

Compliant Solution

This compliant solution uses parentheses to ensure that the expression evaluates as intended:

Code Block
bgColor#ccccff
public class PrintValue {
  public static void main(String[] args) {
    String s = null;
    // Prints "value=0" as expected
    System.out.println("value=" + (s == null ? 0 : 1));
  }
}

Applicability

Mistakes regarding precedence guidelines can cause an expression to be evaluated in an unintended way, which can lead to unexpected and abnormal program behavior.

EXP06-EX0: Parentheses may be omitted from mathematical expressions that follow the algebraic precedence rules. For instance, consider the following expression:

Code Block

x + y * z

By mathematical convention, multiplication is performed before addition; parentheses are redundant in this case.:

Code Block
bgColor#FFCCCC

x + (y * z)

...

Mistakes regarding precedence guidelines can cause an expression to be evaluated in an unintended way. This can lead to unexpected and abnormal program behavior.

Guideline

Severity

Likelihood

Remediation Cost

Priority

Level

EXP06-J

low

probable

medium

P4

L3

Automated Detection

Detection of all expressions using low-precedence operators without parentheses is straightforward. Determining the correctness of such uses is infeasible in the general case; , although heuristic warnings could be useful.

Related Guidelines

C Coding Standard: "EXP00-C. Use parentheses for precedence of operation"

C++ Secure Coding Standard: "EXP00-CPP. Use parentheses for precedence of operation"

Bibliography

Automated Detection

Tool
Version
Checker
Description
Parasoft Jtest
Include Page
Parasoft_V
Parasoft_V
CERT.EXP53.APARENUse '()' to separate complex expressions
SonarQube
Include Page
SonarQube_V
SonarQube_V
S864

Bibliography

[ESA 2005]

Rule 65,

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="c5b24cc7-cfd0-4ca4-a328-7f55b799e8b9"><ac:plain-text-body><![CDATA[

[[ESA 2005

AA. Bibliography#ESA 05]]

Rule 65:

Use parentheses to explicitly indicate the order of execution of numerical operators

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="5d6c6c22-7b13-41c6-86f8-adc93816cafc"><ac:plain-text-body><![CDATA[

[

[Tutorials

2008AA. Bibliography#Tutorials 08]

2013]

[

Expressions, Statements, and Blocks

http://java.sun.com/docs/books/tutorial/java/nutsandbolts/expressions.html]

]]></ac:plain-text-body></ac:structured-macro>

 

Operators

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="e7d89115-dc05-4f13-a44f-5a48fb5b280a"><ac:plain-text-body><![CDATA[

[[Rogue 2000

AA. Bibliography#Rogue 2000]]

Rule 77: Clarify the order of operations with parentheses

]]></ac:plain-text-body></ac:structured-macro>


...

EXP05-J. Use braces for the body of an if, for, or while statement      02. Expressions (EXP)      EXP07-J. Understand the differences between bitwise and logical operatorsImage Added Image Added Image Added