Page History

The type of a narrow string literal is an array of char, and the type of a wide string literal is an array of wchar_t. However, string literals (of both types) are notionally constant and should consequently be protected by const qualification. This recommendation is a specialization of recommendation DCL00-C. Const-qualify immutable objects and also supports rule STR30-C. Do not attempt to modify string literals.

Adding const qualification may propagate through a program; as you add const qualifiers are added, still more become necessary. This phenomenon is sometimes called " const-poisoning. " Const-poisoning can frequently lead to violations of recommendation EXP05-C. Do not cast away a const qualification. While  Although const qualification is a good idea, the costs may outweigh the value in the remediation of existing code.

Noncompliant Code Example (Narrow String Literal)

In the following this noncompliant code example, the const keyword has been omitted.:

char *c = "Hello";

Wiki MarkupIf a statement , such as {{c\[0\] = 'C'}}, were placed following the declaration in the noncompliant code example, the code is likely to compile cleanly, but the result of the assignment is undefined because string literals are considered the assignment would be undefined because string literals are considered constant.

Compliant Solution (Immutable Strings)

In this compliant solution, the characters referred to by the pointer c are const-qualified, meaning that any attempts attempt to assign them to different values is an error.:

const char *c = "Hello";

Compliant Solution (Mutable Strings)

In cases where the string is meant to be modified, use initialization instead of assignment. In this compliant solution, c is a modifiable char array which that has been initialized using the contents of the corresponding string literal.:

char c[] = "Hello";

Wiki MarkupConsequently, a statement such as {{c\[0\] = 'C'}} is valid and behaves as expected.

Noncompliant Code Example (Wide String Literal)

In the following this noncompliant code example, the const keyword has been omitted.:

wchar_t *c = L"Hello";

...

If a statement , such as {{c\[0\] = L'C'}}, were placed following the above this declaration, the code is likely to compile cleanly, but the result of the assignment is undefined as string literals are considered the assignment would be undefined because string literals are considered constant.

Compliant Solution (Immutable Strings)

In this compliant solution, the characters referred to by the pointer c are const-qualified, meaning that any attempts attempt to assign them to different values is an error.:

wchar_t const *c = L"Hello";

...

In cases where the string is meant to be modified, use initialization instead of assignment. In this compliant solution, c is a modifiable wchar_t array which array that has been initialized using the contents of the corresponding string literal.:

wchar_t c[] = L"Hello";

...

Consequently, a statement such as {{c\[0\] = L'C'}} is valid and behaves as expected.

Risk Assessment

Modifying string literals causes undefined behavior, resulting in abnormal program termination and denial-of-service vulnerabilities.

Automated Detection

Related Vulnerabilities

Search for for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

ISO/IEC 9899:1999 Section 6.7.8, "Initialization"

Bibliography

...

...

[Corfield

...

1993

...

]
[Lockheed Martin 2005]	AV Rule 151.1

...

Image Removed      07. Characters and Strings (STR)      Image Added Image Added Image Modified