Java defines the equality operators ==
and !=
for testing reference equality but uses the Object.equals()
method defined in Object
and its subclasses for testing abstract object equality. Naive Naïve programmers often confuse the intent of the ==
operation with that of the Object.equals()
method. This confusion is frequently evident in the context of processing String
processing objects.
As a general rule, use the Object.equals()
method to check whether two objects are abstractly equal to each other and have equivalent contents and use the equality operators ==
and !=
to test whether two references specifically refer to the same object. This latter test is referred to as referential equality. Also For classes that require overriding the default equals()
implementation, care must be taken to also override the hashCode()
method (see MET09-J. Classes that define an equals() method must also define a hashCode() method).
This use of the equality operators also applies to numeric Numeric boxed types (for example, Byte
, Character
, Short
, Integer
, Long
, Float
, and Double
) , although the numeric relational operators should also be compared using Object.equals()
rather than the ==
operator. While reference equality may appear to work for Integer
values between the range −128 and 127, it may fail if either of the operands in the comparison are outside that range. Numeric relational operators other than equality (such as <
, <=
, >
, and >=
) produce results that match those provided for arguments of the equivalent primitive numeric types. See can be safely used to compare boxed primitive types (see EXP03-J. Do not use the equality operators when comparing values of boxed primitives for more information).
Noncompliant Code Example
The reference equality operator ==
evaluates to true
only when the values it compares reference the same underlying object. This noncompliant code example declares two distinct String
objects that contain the same value. The references, however, are unequal because they reference distinct objects.:
Code Block | ||
---|---|---|
| ||
public class StringComparison { public static void main(String[] args) { String str1 = new String("one"); String str2 = new String("one"); System.out.println(isEqual(str1, == str2)); // printsPrints "false" } public static boolean isEqual(String str1, String str2) { boolean result; if (str1 == null) { result = str2 == null; } else { result = str1 == str2; } return result; } } } |
The reference equality operator ==
evaluates to true
only when the values it compares refer to the same underlying object. The references in this example are unequal because they refer to distinct objects.
Compliant Solution (Object.equals()
)
This compliant solution uses the Object.equals()
method when comparing string values.:
Code Block | ||
---|---|---|
| ||
public class StringComparison { public static void main(String[] args) { String str1 = new String("one"); String str2 = new String("one"); System.out.println(isEqualstr1.equals(str1, str2)); // printsPrints "true" } public static boolean isEqual(String str1, String str2) { boolean result; if (str1 == null) { result = (str2 == null); } else { result = str1.equals(str2); } return result; } } |
Compliant Solution (String.intern()
)
Reference equality behaves like abstract object equality when it is used to compare two strings that are results of the String.intern()
method. This compliant solution can be used for uses String.intern()
and can perform fast string comparisons when only one copy of each string the string one
is required in memory.
Code Block | ||
---|---|---|
| ||
public class StringComparison { public static void main(String[] args) { String str1 = new String("one"); String str2 = new String("one"); str1 = str1.intern(); str2 = str2.intern(); System.out.println(str1 == str2); // printsPrints "true" } } |
Use of String.intern()
should be reserved for cases in which the tokenization of strings either yields an important performance enhancement or dramatically simplifies code. Performance Examples include programs engaged in natural language processing and compiler-like tools that tokenize program input. For most other programs, performance and readability are often improved by the use of code that applies the Object.equals()
approach and that lacks any dependence on reference equality.Performance issues arise because
The Java Language Specification (JLS) [JLS 2013] provides very limited guarantees about the implementation of String.intern()
. For example,
- The cost of
String.intern()
grows as the number of intern strings grows. Performance should be no worse than O(n log n), but the Java Language Specification JLS lacks a specific performance guarantee. - Interned strings become In early Java Virtual Machine (JVM) implementations, interned strings became immortal: they cannot be garbage-collectedwere exempt from garbage collection. This can be problematic when large numbers of strings are interned. More recent implementations can garbage-collect the storage occupied by interned strings that are no longer referenced. However, the JLS lacks any specification of this behavior.
- In JVM implementations prior to Java 1.7, interned strings are allocated in the
permgen
storage region, which is typically much smaller than the rest of the heap. Consequently, interning large numbers of strings can lead to an out-of-memory condition. In many Java 1.7 implementations, interned strings are allocated on the heap, relieving this restriction.
Exceptions
- Once again, the details of allocation are unspecified by the JLS; consequently, implementations may vary.
String interning may also be used in programs that accept repetitively occurring strings. Its use boosts the performance of comparisons and minimizes memory consumption.
When canonicalization of objects is required, it may be wiser to use a custom canonicalizer built on top of ConcurrentHashMap
; see Joshua Bloch's Effective Java, second edition, Item 69 [Bloch 2008], for details.
Applicability
Confusing reference equality and object equality can lead to unexpected results.
EXP50-EX0: Using reference equality in place of object equality is permitted only when the defining classes guarantee the existence of, of at most , one object instance for each possible object value. This generally requires that instances of such classes are immutable. The use of static factory methods, rather than public constructors, facilitates instance control, which ; this is a key enabling technique.
Objects that are instances of classes that provide this guarantee obey the invariant that for any two references a
and b
, a.equals(b)
is exactly equivalent to a == b
[Bloch 2008]. The String
class fails to meet these requirements and consequently fails to preserve this invariant.
Another technique is to use an enum
type.
EXP50-EX1: Use reference equality to determine whether two references point to the same object.
Risk Assessment
Using reference equality to compare objects can lead to unexpected results.
Guideline | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
EXP50-JG | low | probable | medium | P4 | L3 |
Automated Detection
The Coverity Prevent Version 5.0 BAD_EQ checker can detect instances where the ==
operator is being used for equality of objects when, ideally, the equals()
method should have been used. The ==
operator could consider the objects to be different, whereas the equals()
method would consider them to be the same.
Findbugs checks this rule for type String
.
Related Guidelines
CWE ID 595, "Comparison of Object References Instead of Object Contents" | |
| CWE ID 597, "Use of Wrong Operator in String Comparison" |
The Elements of Java Style | Rule 79: Use |
Bibliography
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
The Checker Framework |
| Interning Checker | Check for errors in equality testing and interning (see Chapter 5) | ||||||
Parasoft Jtest |
| CERT.EXP50.UEIC | Do not use '==' or '!=' to compare objects | ||||||
SonarQube |
| S1698 |
Bibliography
[Bloch 2008] | Item 69, "Prefer Concurrency Utilities to wait and notify " |
ES, "Comparison of String Objects Using | |
ES: Comparison of String objects using == or !=
] |
...
...