You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 146 Next »

Before the lifetime of the last pointer that stores the return value of a call to a standard memory allocation function has ended, it must be matched by a call to free() with that pointer value.

Noncompliant Code Example

In this noncompliant example, the object allocated by the call to malloc() is not freed before the end of the lifetime of the last pointer text_buffer referring to the object:

#include <stdlib.h>
 
enum { BUFFER_SIZE = 32 };

int f(void) {
  char *text_buffer = (char *)malloc(BUFFER_SIZE); 
  if (text_buffer == NULL) {
    return -1;
  }
  return 0;
}

Compliant Solution

In this compliant solution, the pointer is deallocated with a call to free():

#include <stdlib.h>

enum { BUFFER_SIZE = 32 };

int f(void) {
  char *text_buffer = (char *)malloc(BUFFER_SIZE); 
  if (text_buffer == NULL) {
    return -1;
  }
 
  free(text_buffer);
  return 0;
}

Exceptions

MEM31-EX1: Allocated memory does not need to be freed if it is assigned to a pointer with static storage duration whose lifetime is the entire execution of a program. The following code example illustrates a pointer that stores the return value from malloc() in a static variable:

#include <stdlib.h>
 
enum { BUFFER_SIZE = 32 };

int f(void) {
  static char *text_buffer = NULL;
  if (text_buffer == NULL) {
    text_buffer = (char *)malloc(BUFFER_SIZE); 
    if (text_buffer == NULL) {
      return -1;
    }
  }
  return 0;
}

Risk Assessment

Failing to free memory can result in the exhaustion of system memory resources, which can lead to a denial-of-service attack.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

MEM31-C

Medium

Probable

Medium

P8

L2

Automated Detection

Tool

Version

Checker

Description

CodeSonar8.1p0

ALLOC.LEAK

Leak

Compass/ROSE   

Coverity

2017.07

RESOURCE_LEAK

Finds resource leaks from variables that go out of scope while owning a resource

Cppcheck  2.15 leakReturnValNotUsedReturn value of memory allocation function is not used.

Fortify SCA

5.0

  

Klocwork

2024.3

MLK
UFM.FFM

 

LDRA tool suite

9.7.1

484 S

Fully implemented

Splint

3.1.1  

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

SEI CERT C++ Coding StandardVOID MEM31-CPP. Free dynamically allocated memory exactly once
ISO/IEC TR 24772:2013Memory Leak [XYL]
ISO/IEC TS 17961Failing to close files or free dynamic memory when they are no longer needed [fileclose]
MITRE CWE

CWE-401, Improper Release of Memory Before Removing Last Reference ("Memory Leak")

Bibliography

[ISO/IEC 9899:2011]Subclause 7.22.3, "Memory Management Functions"

 


 

  • No labels