Don't cast to void* and then to another type with a different alignment(DRAFT)

"It is undefined what will happen if a pointer of some type is converted to void*, and then the void* pointer is converted to a type with a stricter alignment requirement" -C99 rationaleV5.10.pdf

Non-compliant Code Example

char *loop_ptr;
int * int_ptr;

int *mkVoidPtr(void *v_pointer){

  return v_pointer;
}
int_ptr = mkVoidPtr(loop_ptr);

In this example the v_pointer might be aligned on a 1 byte boundary. Once it is cast to an int some architectures will require it to be on 4 byte boundaries. Pointers are often cast because a void* cannot be dereferenced. Careless coding can result in an arbitrary pointer type being used irregardless of its alignment.

Implementation Details

List of common alignments for Microsoft, Borland and GNU compilers to x86

Compliant Solution

Make specific functions (avoid use of void*)
or
use offsetof from <stddef.h> to create an alignof function that will return the alignment
of anything that is not:

• An lvalue representing a bit field
• A function type
• An undefined structure or class
• An incomplete type (such as void)

int *loop_ptr;
int * int_ptr;

int *loopFunction(int *v_pointer)
{    return v_pointer; }
int_ptr = loopFunction(loop_ptr);

Risk Assessment

Accessing a pointer that is no longer on the correct access boundary can cause a program to crash, give wrong information or have slow pointer accesses (if the architecture does not care about alignment).

References

• Bryant, Randal and O'Hallaron, David. [ 2003 ] 2001 Computer Systems: A Programmer's Perspective. Prentice Hall. ISBN 0-13-034074-X.

• http://www.open-std.org/jtc1/sc22/wg14/www/C99RationaleV5.10.pdf