SEI CERT C Coding Standard

Space shortcuts

Page tree

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

Version 1 Next »

The readlink() function reads where a link points to.
the function with its arguments is:
readlink(link, buf, len);

Non-Compliant Solution

readlink() never 0-terminates by itself, so you have to do it by yourself. People often seem to forget this, leading to infoleaks or sometimes memory corruption.
another thing people like to do is:

len = readlink(link, buf, sizeof(buf));
buf[len] = '\0';

There are two problems here, readlink() can return -1 if it fails and hence causing an off-by-one underflow, so always check the readlink return value. The other problem that can occur is that readlink returns how many byted got written to the buffer, in this case it can write up to sizeof(buf) bytes. if it does you basicly end up doing:
bufsizeof(buf) = '\0'; which is an off-by-one overflow.

Compliant Solution

#include <unistd.h>

char buf[1024];
ssizet_t len;
...
if ((len = readlink("/modules/pass1", buf, sizeof(buf)-1)) != -1)
    buf[len] = '\0';

References

  • No labels