FIO45-C. Prevent TOCTOU race conditions

A TOCTOU (time-of-check, time-of-use) race condition occurs when a program performs two or more accesses on a filename or path. Typically, the first access is a check to verify some attribute of the file, followed by a call to use the file. An attacker can alter the file between the two accesses, causing the check to succeed but the use to fail. Worse, the use can operate on a different file than the check.

A program that performs a file operation on a filename or path twice creates a race window between the two file operations. This race window comes from the assumption that the filename refers to the same file both times. If an attacker can modify the file, remove it, or replace it with a different file, then this assumption will not hold.

Noncompliant Code Example (POSIX write)

If an existing file is opened for writing, the file's previous contents are destroyed. This noncompliant code example tries to prevent an existing file from being overwritten by first ensuring that a file does not exist before opening it for writing. An attacker can exploit the race window between the access and the open to cause fopen() to overwrite an existing file.

#include <stdio.h>
#include <unistd.h> 

void open_some_file(const char *file) {
  FILE *f; 
  if (access(file, R_OK | W_OK) == 0) {
    printf("access granted.\n");
    f = fopen(file, "wb+");
    if (NULL == f) {
      /* Handle error */
    }
    /* write to file */
    fclose(f);
  }
}

Compliant Solution (C11 write)

This compliant solution uses the x mode of fopen(), which was added in C11. This mode causes fopen() to fail if the file exists. This check and subsequent open is done without creating a race window. Note that the x mode provides exclusive access to the file if the operating platform provides this support.

#include <stdio.h>

void open_some_file(const char *file) {
  FILE *f; 
  f = fopen(file, "wb+x");
  if (f == NULL) {
    /* Handle error */
  }
  printf("access granted.\n");
  /* write to the file */
  fclose(f);
}

Compliant Solution (POSIX write)

This compliant solution uses the O_CREAT and O_EXCL flags of POSIX's open() system call. These flags cause open() to fail if the file exists.

#include <stdio.h>
#include <unistd.h>
#include <fcntl.h>

void open_some_file(const char *file) {
  int fd = open(file, O_CREAT | O_EXCL | O_RDWR);
  if (fd != -1) {
    FILE *f = fdopen(fd, "rw+");
    if (f != NULL) {
      printf("access granted.\n");
      /* write to file */
      fclose(f);
    }
    close(fd);
  }
}

Noncompliant Code Example (POSIX read)

This noncompliant code example attempts to ensure that an open will succeed by first calling the POSIX access() function, which returns zero if the file exists and can be accessed using the specified permissions. An attacker can exploit the race window between the access and the open to cause fopen() to fail in spite of the check.

#include <stdio.h>
#include <unistd.h> 

void open_some_file(const char *file) {
  FILE *f; 
  if (access(file, R_OK | W_OK) == 0) {
    printf("access granted.\n");
    f = fopen(file, "rb+");
    if (NULL == f) {
      /* Handle error */
    }
    /* read file */
    fclose(f);
  }
}

Compliant Solution (read)

This compliant solution dispenses with an access call and merely relies on fopen() to verify the file.

#include <stdio.h>

void open_some_file(const char *file) {
  FILE *f = fopen(file, "rb+");
  if (NULL == f) {
    /* Handle error */
  }
  printf("access granted.\n");
  /* read file */
  fclose(f);
}

Exceptions

FIO45-EX1: Accessing a path multiple times is permitted if it is requested specifically by a user. A program that accepts commands from a user to read or write a specific filename does not violate this standard. Example programs would include file managers or text editors.

FIO45-EX2: Accessing a path multiple times is permitted if the path can not be modified by an attacker. This could occur, for example, if the path refers to a secure directory (for more information, see FIO15-C. Ensure that file operations are performed in a secure directory).

FIO45-EX3: Accessing a path multiple times is permitted if the program is able to verify that every operation indeed operates on the same file.

This code example demonstrates how to verify that two accesses are indeed the same file in POSIX. In POSIX, every file can be uniquely identified by using its device and i-node attributes. This code example checks that a filename does not refer to a symbolic link, using lstat(); the call also retrives its device and i-node. The file is subsequently opened. Finally, the program verifies that the file that was opened is the same one (matching device and inodes) as the file that was verified not to be a symbolic link.

int open_real_file(char *filename, int flags) {
  struct stat lstat_info;
  struct stat fstat_info;
  int fd;

  if (lstat(filename, &lstat_info) == -1) {
    /* file does not exist, handle error */
  }

  if (!S_ISLNK(lstat_info.st_mode)) {
    /* file is a symlink, handle error */
  }

  fd = open(filename, flags);
  if (fd == -1) {
    /* file has disappeared, handle error */
  }

  if (fstat(fd, &fstat_info) == -1) {
    /* handle error */
  }

  if (!(lstat_info.st_ino == fstat_info.st_ino  &&
       (lstat_info.st_dev == fstat_info.st_dev) {
    /* open file is not non-symlink file, handle error */
  }

  /* fd is true open file, and file was not symlink */
  return fd;
}

Risk Assessment

TOCTOU race conditions can result in unexpected behavior, including privilege escalation.

Bibliography