MEM10-A. Define and use a pointer validation function

Many functions accept pointers as arguments. If the function dereferences an invalid pointer (see [EXP34-C. Ensure a null pointer is not dereferenced]), or reads or writes to a pointer that does not refer to an object, the results are undefined. Typically the program will terminate abnormally when the invalid pointer is dereferenced, but it is possible for an invalid pointer to be dereferenced, and its memory changed, without abnormal termination [[Jack 07]]. Such programs can be difficult to debug because of the difficulty in determining if a pointer is valid.

One source of prevention of invalid pointers is a function that could take a pointer and indicate if the pointer is valid or invalid, for some definition of valid. For instance, the following function declares any pointer to be valid except NULL.

int valid(void *ptr) {
  return (ptr != NULL);
}

Some platforms have platform-specific pointer validation tools.

The following code relies on the _etext address, which is provided by many platforms, including AIX, Linux, QNX, IRIX, and Solaris. It is not POSIX-compliant, nor is it available on Windows.

#include <stdio.h>
#include <stdlib.h>

int invalid(void *p) {
  extern char _etext;
  return (p == NULL) || ((char*) p < &_etext);
}

int global;

int main(void) {
  int local;
  int *p;

  printf("pointer to local var invalid? %d\n", invalid(&local));
  printf("pointer to static var invalid? %d\n", invalid(&global));
  printf("pointer to function invalid? %d\n", invalid((void *)main));

  p = (int *)malloc(sizeof(int));
  printf("pointer to heap invalid? %d\n", invalid(p));
  printf("pointer to end of allocated heap invalid? %d\n", invalid(p++));
  printf("pointer to freed heap invalid? %d\n", invalid(p--));
  printf("null pointer invalid? %d\n", invalid(NULL));

  return 0;
}

On a Linux platform, this program produces the following output:

pointer to local var invalid? 0
pointer to static var invalid? 0
pointer to function invalid? 1
pointer to heap invalid? 0
pointer to end of allocated heap invalid? 0
pointer to freed heap invalid? 0
null pointer invalid? 1

As you can see, the invalid() function is not perfect; it only identifies null pointers and pointers to functions as invalid.

Non-Compliant Code Example

This function increments the value pointed to by its argument. It also ensures that its argument is not a null pointer. But the pointer could still be invalid, causing the function to corrupt memory, or possibly terminate abnormally.

void incr(int *intptr) {
  if (intptr == NULL) {
    /* handle error */
  }
  *intptr++;
}

Compliant Solution

By using the invalid() function defined above, the function is less likely to modify memory outside its bounds.

void incr(int *intptr) {
  if (invalid( intptr)) {
    /* handle error */
  }
  *intptr++;
}

Compliant Solution (assert)

Since invalid pointers are often indicative of a bug in the program, one can use the assert() macro to terminate immediately if an invalid pointer is discovered (see MSC11-A. Incorporate diagnostic tests using assertions).

#include <assert.h>

void incr(int *intptr) {
  assert(!invalid( intptr));
  *intptr++;
}

Risk Assessment

A pointer validation library can be used to identify and so prevent the execution of vulnerable code.

Failure to clear memory can result in leaked information. Occasionally, it can also lead to buffer overflows if the program falsely assumes that a null-termination byte is present.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[ISO/IEC 9899:1999]] Section 6.3.2.3, "Pointers"
[[Jack 07]]
[[van Sprundel 06]]

MEM09-A. Do not assume memory allocation routines initialize memory      08. Memory Management (MEM)