MEM30-C. Do not access freed memory

Accessing memory once it is freed may corrupt the data structures used to manage the heap. References to memory that has been deallocated are referred to as dangling pointers. Accessing a dangling pointer can lead to security vulnerabilities.

When memory is freed, its contents may remain intact and accessible. This is because it is at the memory manager's discretion when to reallocate or recycle the freed chunk. The data at the freed location may appear valid. However, this can change unexpectedly, leading to unintended program behavior. As a result, it is necessary to guarantee that memory is not written to or read from once it is freed.

Non-Compliant Code Example

This example from Kerrighan & Ritchie [[Kerrighan 88]] shows items being deleted from a linked list. Because p is freed before the p->next is executed, p->next reads memory that has already been freed.

for(p = head; p != NULL; p = p->next) {
  free(p);
}

Compliant Solution

To correct this error, a reference to p->next is stored in q before freeing p.

for (p = head; p != NULL; p = q) {
  q = p->next;
  free(p);
}

Non-Compliant Code Example

In this example, buff is written to after it has been freed. These vulnerabilities can be relatively easily exploited to run arbitrary code with the permissions of the vulnerable process and are seldom this obvious. Typically, allocations and frees are far removed making it difficult to recognize and diagnose these problems.

int main(int argc, char *argv[]) {
  char *buff;

  buff = malloc(BUFSIZE);
  if (!buff) {
     /* handle error condition */
  }
  ...
  free(buff);
  ...
  strncpy(buff, argv[1], BUFSIZE-1);
}

Compliant Solution

Do not free the memory until it is no longer required.

int main(int argc, char *argv[]) {
  char *buff;

  buff = malloc(BUFSIZE);
  if (!buff) {
     /* handle error condition */
  }
  ...
  strncpy(buff, argv[1], BUFSIZE-1);
  ...
  free(buff);

}

Risk Assessment

Reading memory that has already been freed can lead to abnormal program termination and denial-of-service attacks. Writing memory that has already been freed can lead to the execution of arbitrary code with the permissions of the vulnerable process.

References

[[ISO/IEC 9899-1999]] Section 7.20.3.2, The free function
[[Seacord 05]]/Chapter 4, Dynamic Memory Management
[[Kerrighan 88]]/ Section 7.8.5, Storage Management
[OWASP, Using freed memory http://www.owasp.org/index.php/Using_freed_memory]/
[[Viega 05]]/ Section 5.2.19 Using freed memory