You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 22 Next »

Do not send an uncaught signal to a thread to kill it because the signal kills the entire process rather than killing just the individual thread. This rule is a specific instance of recommendation SIG02-C. Avoid using signals to implement normal functionality.

Noncompliant Code Example

This code uses the pthread_kill() function to send a SIGKILL signal to the created thread. The thread receives the signal and the entire process is terminated.

void func(void *foo){
  /* Execution of thread */
}

int main(void) {
  int result;
  pthread_t thread;

  if ((result = pthread_create(&thread, NULL, func, 0)) != 0) {
    /* Handle Error */
  }
  if ((result = pthread_kill(thread, SIGKILL)) != 0) {
    /* Handle Error */
  }

  /* Continue executing until the signal kills the process */

  return 0;
}

Compliant Solution

This code instead uses the pthread_cancel() function to terminate the thread. The thread continues to run until it reaches a cancellation point. See [Open Group 2004] for lists of functions that are required and allowed to be cancellation points. If the cancellation type is set to asynchronous, the thread is terminated immediately. However, POSIX only requires the pthread_cancel(), pthread_setcancelstate(), and pthread_setcanceltype() functions to be async-cancel safe. An application that calls other POSIX functions with asynchronous cancellation enabled is non-conforming. Consequently, we recommend disallowing asynchronous cancellation, as expalined by rule POS47-C. Do not use threads that can be cancelled asynchronously.

void func(void *foo) {
  /* Execution of thread */
}

int main(void) {
  int result;
  pthread_t thread;

  if ((result = pthread_create(&thread, NULL, func, 0)) != 0) {
    /* Handle Error */
  }
  if ((result = pthread_cancel(thread)) != 0) {
    /* Handle Error */
  }

  /* Continue executing */

  return 0;
}

Risk Assessment

Sending the signal to a process causes it to be abnormally terminated.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

POS44-C

low

probable

low

P6

L2

Bibliography

[OpenBSD] signal() Man Page
[MKS] pthread_cancel() Man Page
[Open Group 2004] Threads Overview


POS41-C. When a thread exit status is not of concern, pthread_detach() or an equivalent function must be used      50. POSIX (POS)      POS45-C. Avoid memory leaks and cleanup thread specific data for a key by defining an explicit destructor

  • No labels