PRE07-A. Avoid using repeated question marks

Two consecutive question marks signify the start of a trigraph sequence.

According to the C99 Standard:

All occurrences in a source file of the following sequences of three characters (ie. trigraph sequences) are replaced with the corresponding single character.

??=	#		??)	]		??!	|
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="d008c742-bca5-4be8-96e0-ba12a7ef6119"><ac:plain-text-body><![CDATA[	??(	[		??'	^		??>	}	]]></ac:plain-text-body></ac:structured-macro>
??/	\		??<	{		??-	~

Non-compliant Code Example

In this non-compliant code example, a++ is not executed, as the trigraph sequence ??/ is replaced by \, logically putting a++ on the same line as the comment.

// what is the value of a now??/
a++;

Compliant Solution

The following compliant solution eliminates the accidental introduction of the trigraph.

/* what is the value of a now */
a++;

Non-compliant Code Example

This non-compliant code has the trigraph sequence of ??! included, which is replaced by the character |.

size_t i;
/* assignment of i */
if (i > 9000) {
   puts("Over 9000!??!");
}

The above code prints out Over 9000!| if a C99 Compliant compiler is used.

Compliant Solution

The compliant solution uses string concatenation to place the two question marks together, as they will be interpreted as beginning a trigraph sequence otherwise.

size_t i;
/* assignment of i */
if (i > 9000) {
   puts("Over 9000!?""?!");
}

The above code will print out Over 9000!??!, as intended.

Risk Assessment

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[ISO/IEC 9899-1999]] Section 5.2.1.1, "Trigraph sequences"
[Wikipedia] "C Trigraphs"

PRE06-A. Enclose header file in an inclusion sandwich       01. Preprocessor (PRE)       PRE08-A. Guarantee header file names are unique