DCL01-J. Do not declare more than one variable per declaration

Declaring multiple variables in a single declaration may cause confusion regarding the types of the variables and their initial values. In particular do not declare any of the following in a single declaration:

• variables or fields and functions
• variables or fields of different types
• initialized and uninitialized variables or fields

In general, you should declare each variable on its own line with an explanatory comment about the role of the variable. Although not required for conformance with this guide, this practice is also recommended in the Code Conventions for the Java Programming Language Conventions 2009 Section 6.1, "Number Per Line".

When more than one variable is declared in a single declaration, ensure that the type and initial value of the variable are self evident.

This guideline applies to:

• local variable declaration statements (JLS §14.4)
• field declarations (JLS §8.3)
• field (constant) declarations (JLS §9.3)

Noncompliant Code Example (initialization)

This noncompliant code example might lead a programmer or reviewer to mistakenly believe that both i and j are initialized to 1. In fact, only j is initialized; i remains uninitialized.

int i, j = 1;

Compliant Solution (initialization)

In this compliant solution, it is readily apparent that both i and j are initialized to 1.

int i = 1;  // purpose of i...
int j = 1;  // purpose of j...

Noncompliant Code Example (variables or fields and functions)

This noncompliant code example is easily misunderstood by a programmer.

long dbaddr, getDbaddr(); 

compliant Solution (variables or fields and functions)

The purpose of each identifier is readily apparent in this compliant solution.

long dbaddr;       // db address
long getDbaddr();  // function to access db address

Noncompliant Code Example (different types)

In this noncompliant code example, a programmer or code reviewer could mistakenly believe that the variables src and c are both declared to be type int. In fact, src is of type int[], while c has a type of int.

int src[], c;

Note: this example declares the array in an antiquated and unpopular style, with the brackets appearing after the variable name. Arrays should be declared type[] name for improved clarity.

Compliant Solution (different types)

In this compliant solution, each variable is declared on a separate line, using the preferred style for declaring arrays.

int[] src;   /* source array */
int c;       /* max value    */

Although this change has no effect on compilation, it clarifies the programmer's intent.

Noncompliant Code Example

In this noncompliant code example, the programmer declared multiple variables, including an array, on the same line. All instances of the type T have access to methods of the class Object. However, it is easy to forget that arrays require special treatment when some of these methods are overridden.

public class Example<T> {
  private T a, b, c[], d;

  public Example(T in){
    a = in;
    b = in;
    c = (T[]) new Object[10];
    d = in;
  }
}

When a method of Object such as toString() is overridden, a programmer might accidentally provide an implementation for type T that fails to consider that c is an array of T, rather than a reference to an object of type T.

// The oversight leads to an incorrect implementation
public String toString(){
  return a.toString() + b.toString() + c.toString() + d.toString();
}

However, the programmer's actual intent might have been to invoke toString() on each individual element of the array c.

// Correct functional implementation
public String toString(){
  String s = a.toString() + b.toString();
  for(int i = 0; i < c.length; i++){
    s += c[i].toString();
  }
  s += d.toString();
  return s;
}

Compliant Solution

This compliant solution places each declaration on its own line, as well as using the preferred notation for array declaration.

public class Example {
  private T a;   // purpose of a...
  private T b;   // purpose of b...
  private T[] c; // purpose of c[]...
  private T d;   // purpose of d...

  public Example(T in){
    a = in;
    b = in;
    c = (T[]) new Object[10];
    d = in;
  }
}

Exceptions

DCL01-EX1: Note that the declaration of a loop counter in a for statement is in violation of this recommendation because the declaration is not on its own line with an explanatory comment about the role of the variable. However, declaration of loop indices in for statements is not only a common idiom; it also provides the benefit of restricting the scope of the loop index to that of the for loop itself. These are sufficient reasons to relax this guideline in this specific case.

Declarations of loop indices should be included within a for statement:

for (int i = 0; i < mx; ++i ) {
  /* ... */
}

Risk Assessment

Declaration of multiple variables per line can reduce code readability and lead to programmer confusion.

Related Guidelines

C Secure Coding Standard: DCL04-C. Do not declare more than one variable per declaration

C++ Secure Coding Standard: DCL04-CPP. Do not declare more than one variable per declaration

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this guideline on the CERT website.

Bibliography

[[Conventions 2009]] Section 6.1, "Number Per Line"
[[ESA 2005]] Rule 9: Put single variable definitions in separate lines.
[[JLS 2005]] Section 8.3, "Field Declarations", Section 9.3, "Field (Constant) Declarations"Section 14.4, "Local Variable Declaration Statements" Section 6.1, "Declarations", Section 4.3.2, "The class Object"

DCL00-J. Use visually distinct identifiers      03. Declarations and Initialization (DCL)      DCL02-J. Use meaningful symbolic constants to represent literal values in program logic