You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 8 Next »

Avoid the use of numerical values or "magic numbers" in code when possible. Appropriately named symbolic constants make code more readable rather than checks against a specific number. If a specific number needs to be changed reassigning a symbolic value is much easier than replacing a specific number in the code because each case has to be checked specifically.

Non Compliant Code Example

if (age >= 18) {
  takevote(personID);
}
... 
if (age <= 18) {
  checkSchoolEnrollment(personID);
}

Compliant Solution

if (age >= ADULT_AGE) {
  takevote(personID);
}
... 
if (age <= ADULT_AGE) {	
  checkSchoolEnrollment(personID);
}  

In the compliant code it is easy to check if the user is an adult and process accordingly. If the definition of adult changes during iterations of the codebase it is much simpler to replace the value for ADULT_AGE then search for instance of 18 and see if they're appropriate for change.

Risk Assessment

Mistakes regarding numeric values can cause unintended consequences if changes are not made uniformly

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

EXP00-A

1 (low)

1(unlikely)

2 (medium)

P2

L3

References

Source: http://www.doc.ic.ac.uk/lab/cplus/c++.rules/chap10.html

  • No labels