CON05-J. Do not invoke Thread.run()

It is critical to ensure that threads are started correctly. Thread start-up can be misleading because sometimes the code appears to be performing the function correctly, when in fact it may be executing in the wrong thread.

The Thread.start() method starts executing a thread's run() method in the respective thread. It is a mistake to directly invoke the run() method on a Thread object. When invoked directly, the statements in the run() method execute in the current thread instead of the newly created thread. Furthermore, if the Thread object is not constructed from a Runnable object but rather by instantiating a subclass of Thread that does not override the run() method, then a call to the subclass's run() method invokes Thread.run() which does nothing.

Noncompliant Code Example

This noncompliant code example explicitly invokes run() in the context of the current thread.

public final class Foo implements Runnable {
  public void run() {
    // ...
  }
  
  public static void main(String[] args) {
    Foo foo = new Foo();
    new Thread(foo).run();
  }
}

The start() method is not invoked on the new thread because of the incorrect assumption that run() starts the new thread. Consequently, the statements in the run() method execute in the same thread instead of the new one.

Compliant Solution

This compliant solution correctly uses the start() method to start a new thread. The start() method internally invokes the run() method in the new thread.

public final class Foo implements Runnable {
  public void run() {
    // ...
  }
  
  public static void main(String[] args) {
    Foo foo = new Foo();
    new Thread(foo).start();
  }
}

Exceptions

EX1: The run() method may be invoked when unit testing its functionality. Note that a class cannot be tested for multithreaded use by invoking run() directly.

EX2: When invoking in the current thread, the run() method of a Thread object that has been constructed with a runnable argument, the object should first be cast to a Runnable.

Thread thread = new Thread(new Runnable() {
    public void run() {
      // ...
    }
  });
// Invoking thread.run() is bad; the programmer probably meant thread.start()
((Runnable) thread).run();  // (Admissible) Warning: This does not start a new thread 

Casting a thread to a Runnable before calling run() serves to document the intention of explicitly calling Thread.run(). Adding a disclaimer alongside the invocation is highly recommended.

Risk Assessment

Failing to start threads correctly can cause unexpected behavior.

Automated Detection

TODO

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[API 06]] Interface Runnable and class Thread

[!The CERT Sun Microsystems Secure Coding Standard for Java^button_arrow_left.png!]      [!The CERT Sun Microsystems Secure Coding Standard for Java^button_arrow_up.png!]      [!The CERT Sun Microsystems Secure Coding Standard for Java^button_arrow_right.png!]