...
| Code Block | ||||
|---|---|---|---|---|
| ||||
int privileges;
if (invalid_login()) {
if (allow_guests()) {
privileges = GUEST;
}
} else {
privileges = ADMINISTRATOR;
}
|
Risk Assessment
Recommendation | Severity | Likelihood | Remediation Cost | Priority | Level |
|---|---|---|---|---|---|
EXP19-C | Medium | Probable | Medium | P8 | L2 |
Automated Detection
Tool | Version | Checker | Description | ||||||
| Astrée |
| compound-ifelse compound-loop | Fully checked | ||||||
| Klocwork |
| MISRA.IF.NO_COMPOUND MISRA.STMT.NO_COMPOUND |
| LDRA tool suite |
| 11 S, 12 S, 428 S | Fully Implemented | ||||||
| Parasoft C/C++test |
|
|
| MISRA2004-14_8 | Fully implemented | ||||||
| PRQA QA-C |
| 2212 |
| RuleChecker |
| compound-ifelse compound-loop | Fully checked | ||||||
| SonarQube C/C++ Plugin |
| S121 |
| PVS-Studio | 6.22 | V563, V628, V640, V705 | General analysis rule set |
Related Vulnerabilities
CVE-2014-1266 was due, in large part, to failing to follow this recommendation. There is a spurious "goto fail" statement on line 631 of sslKeyExchange.c. This "goto" gets executed unconditionally, even though it is indented as if it were part of the preceding "if" statement. As a result, the call to sslRawVerify (which performs the actual signature verification) is rendered dead code. [ImperialViolet 2014]. If the body of the "if" statement had been enclosed in braces, then this defect likely would not have happened.
Related Guidelines
| MISRA C:2012 | Rule 15.6 (required) |
Bibliography
...
...