Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: First sentence in Compliant Solution 1 is missing something.

For bit-fields, it is implementation-defined whether the specifier int designates the same type as signed int or the same type as unsigned int.
Also, C99 requires that "If an int can represent all values of the original type, the value is converted to an int; otherwise, it is converted to an unsigned int."
In the following example:

...

The type of the expression (bits.a << 24) is compiler dependent and may be either signed or unsigned depending on their the compiler's interpretation of the standard.
The first interpretation is that when this value is used as an rvalue (e.g., lvalue = rvalue;) (wink) the type is "unsigned int" as declared.  An unsigned int cannot be represented as an int, so integer promotions require that this be an unsigned int, and hence "unsigned".

The second interpretation is that this is an 8-bit integer.  As a result, this eight bit value can be represented as an int, so integer promotions require that it be converted to int, and hence "signed".

...

<< The following examples need to be completed and tested >>

Non-

...

Compliant Code Example 1

In the following non-compliant code example, cBlocks is multiplied by 16 and the result is stored in the unsigned long long int alloc.  The result of this multiplication can overflow because it is a 32 bit operation and the resulting value stored in alloc is invalid.

Code Block
struct {
    unsigned long long size: 24;
} ull;

void* AllocBlocks(ull cBlocks) {
  if (cBlocks == 0) return NULL;
  unsigned long long alloc = cBlocks.size * 16;
  return (alloc < UINT_MAX)
    ? malloc(cBlocks * 16)
    : NULL;
}

...

On architectures where unsigned long long int is guaranteed to have 2x the number of bits as size_tupcast the variable used in the multiplication to a 64-bit value.  This ensures that the multiplication operation is performed.

Code Block
void* AllocBlocks(size_t cBlocks) {
  if (cBlocks == 0) return NULL;
  unsigned long long alloc =
           (unsigned long long)cBlocks.size * 16;
  return (alloc < UINT_MAX)
    ? malloc(cBlocks * 16)
    : NULL;
}

The assumption concerning the relationship of unsigned long long int and size_t must be document documented in the header for each file that depends upon this assumption for correct execution.

...