Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

CWE 234 Missing Parameter "If too few arguments are sent to a function, the function will still pop the expected number of arguments from the stack. Potentially, a variable number of arguments could be exhausted in a function as well."-http://cwe.mitre.org/

Non compliant code

Code Block

function(1, 2);
...
void function(int one, int two, int three){
printf("args %d %d $d, one, two, three);
}

solution: "Implementation: Forward declare all functions. This is the recommended solution. Properly forward declaration of all used functions will result in a compiler error if too few arguments are sent to a function." -http://cwe.mitre.org/

Compliant code

Code Block

void function(int one, int two, int three); //at top of file or in .h file
... 
function(1,2) //compiler error

Risk Assesment