Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Implementation Details

On x86-32 platforms, the remainder operator for signed integers is implemented by the idiv instruction the idiv instruction code, along with the divide operator. Because LONGBecause LONG_MIN / -1 overflows1 overflows, this code will throw a floating-point exception on LONGon LONG_MIN % -1.

Compliant Solution

This compliant solution also tests the remainder operands to guarantee there is no possibility of an overflow:

...

The C Standard, 6.5.7, paragraph 4 [ISO/IEC 9899:2011], states

...

In almost every case, an attempt to shift by a negative number of bits or by more bits than exist in the operand indicates a logic error. These issues are covered by INT34-C. Do not shift an expression by a negative number of bits or by greater than or equal to the number of bits that exist in the operand.

Noncompliant Code Example

This noncompliant code example performs a left shift, after verifying that the number being shifted is not negative, and the number of bits to shift is valid.  The PRECISION() macro and popcount() function provide the correct precision for any integer type (see INT35-C. Use correct integer precisions). However, because this code does no overflow check, it can result in an unrepresentable value. 

...

Compliant Solution

This compliant solution eliminates the possibility of overflow resulting from a left-shift operation:

...

...