...
Code Block | ||||
---|---|---|---|---|
| ||||
#define CUBE(I) (I * I * I)
|
...
Code Block | ||||
---|---|---|---|---|
| ||||
int a = 81 / CUBE(2 + 1);
|
...
Code Block | ||||
---|---|---|---|---|
| ||||
int a = 81 / (2 + 1 * 2 + 1 * 2 + 1); /* evaluates to 11 */
|
...
Code Block | ||||
---|---|---|---|---|
| ||||
#define CUBE(I) ( (I) * (I) * (I) )
int a = 81 / CUBE(2 + 1);
|
...
PRE01-EX1: When the parameter names are surrounded by commas in the replacement text, regardless of how complicated the actual arguments are, there is no need for parenthesizing the macro parameters. Because commas have lower precedence than any other operator, there is no chance of the actual arguments being parsed in a surprising way. Comma separators, which separate arguments in a function call, also have lower precedence than other operators, although they are technically different from comma operators.
Code Block |
---|
#define FOO(a, b, c) bar(a, b, c)
/* ... */
FOO(arg1, arg2, arg3);
|
PRE01-EX2: Macro parameters cannot be individually parenthesized when concatenating tokens using the ##
operator, converting macro parameters to strings using the #
operator, or concatenating adjacent string literals. The JOIN()
macro below concatenates both arguments to form a new token. The SHOW()
macro converts the single argument into a string literal, which is then concatenated with the adjacent string literal to form the format specification in the call to printf()
.
Code Block |
---|
#define JOIN(a, b) (a ## b)
#define SHOW(a) printf(#a " = %d\n", a)
|
...
Recommendation | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
PRE01-C | medium | probable | low | P12 | L1 |
Automated Detection
Tool | Version | Checker | Description |
---|---|---|---|
78 S | Fully Implemented | ||
macrbody | Fully Implemented |
Tool | Version | Checker | Description | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
|
| ||||||||||||
|
|
|
|
...