Page History

...

float pi = 3.14159f;
float degrees;
float radians;
/* ... */
radians = degrees * PIpi / 180;

Compliant Solution

In this compliant solution, pi is declared as a const-qualified object.

...

char *strcat_nc(char *s1, char *s2);

char *str1 = "str1";
const char *str2 = "str2";
char str3[] = "str3";
const char str4[] = "str4";

strcat_nc(str1str3, str2);  /* different 'const' qualifiers */
strcat_nc(str3str1, str1str3); 
strcat_nc(str4, str3);  /* different 'const' qualifiers */

The function behaves would behave the same as strcat(), but results in spurious warnings when the second argument is a const-qualified argument, as in the initial invocation strcat_nc(str1, str2)the compiler generates warnings in incorrect locations, and fails to generate them in correct locations.

In the first strcat_nc() call, the compiler will generate a warning about attempting to cast away const on str2. This is a good warning, as strcat_nc() does not modify its second argument, yet fails to declare it const.

In the second strcat_nc() call, the compiler will happily compile the code with no warnings, but the resulting code will attempt to modify the "str1" literal, which may be impossible; the literal may not be defined in the heap. This violates STR05-A. Prefer making string literals const-qualified.

In the final strcat_nc() call, the compiler generates a warning about ateempting to cast away const on str4. This is a valid warning.

Compliant Solution

This compliant solution uses the prototype for the strcat() from C90. Although the restrict type qualifier did not exist in C90, const did. In general, the arguments should be declared in a manner consistent with the semantics of the function. In the case of strcat(), the initial argument can be changed by the function while the second argument cannot.

char *strcat(char *s1, const char *s2); 

char *str1 = "str1";
const char *str2 = "str2";
char str3[] = "str3";
const char str4[] = "str4";

strcat(str1str3, str2);  
strcat(str3str1, str1str3);  /* Note: reversed args */
strcat(str4, str3);  /* different 'const' qualifiers */

The const-qualification of the second argument s2 eliminates the spurious warning in the initial invocation, but maintains the valid warning on the final invocation in which a const-qualified object is passed as the first argument (which can change). Finally, the middle strcat() invocation is now valid, as str1 is a valid destination string, as the string exists on the stack and may be safely modified.

Risk Assessment

Failing to const-qualify immutable objects can result in a constant being modified at runtime.

...