Null pointer dereferencing occurs when a variable bound to the null
value is treated as if it were a valid object reference and used without checking its state. This condition results in a NullPointerException
, which can in turn result in a denial of service. The denial of service is caused by the exception interrupting the program or thread, and probably causing it to terminate. Termination is likely because catching NullPointerException
is forbidden by ERR08-J. Do not catch NullPointerException or any of its ancestors. Consequently, code must never dereference null pointers.
Noncompliant Code Example
This noncompliant example shows a bug in Tomcat version 4.1.24, initially discovered by Reasoning [Reasoning 2003]. The cardinality
method was designed to return the number of occurrences of object obj
in collection col
. One valid use of the cardinality
method is to determine how many objects in the collection are null
. However, because membership in the collection is checked using the expression obj.equals(elt)
, a null pointer dereference is guaranteed whenever obj
is null
and elt
is not null
.
Code Block | ||
---|---|---|
| ||
public static int cardinality(Object obj, final Collection col) { int count = 0; if (col == null) { return count; } Iterator it = col.iterator(); while (it.hasNext()) { Object elt = it.next(); if ((null == obj && null == elt) || obj.equals(elt)) { // null pointer dereference count++; } } return count; } |
Compliant Solution
This compliant solution eliminates the null
pointer dereference.
Code Block | ||
---|---|---|
| ||
public static int cardinality(Object obj, final Collection col) { int count = 0; if (col == null) { return count; } Iterator it = col.iterator(); while (it.hasNext()) { Object elt = it.next(); if ((null == obj && null == elt) || (null != obj && obj.equals(elt))) { count++; } } return count; } |
Explicit null checks as shown here an acceptable approach to eliminating null pointer dereferences.
Noncompliant Code Example
This noncompliant code example defines an isName()
method that takes a String argument and returns true if the given string is a valid name. A valid name is defined as two capitalized words separated by one or more spaces.
Code Block | ||
---|---|---|
| ||
public boolean isName(String s) { String names[] = s.split(" "); if (names.length != 2) { return false; } return (isCapitalized(names[0]) && isCapitalized(names[1])); } |
Method isName()
is noncompliant because a null
argument results in isName()
dereferencing a null pointer.
Compliant Solution
This compliant solution demonstrates that the context in which code appears can impact its compliance. This example includes the same isName()
method as the previous noncompliant example, but as part of a more general method that tests string arguments.
Code Block | ||
---|---|---|
| ||
public class Foo { private boolean isName(String s) { String names[] = s.split(" "); if (names.length != 2) { return false; } return (isCapitalized(names[0]) && isCapitalized(names[1])); } public boolean testString(String s) { if (s == null) return false; else return isName(s); } } |
The isName()
method is a private method with only one caller in its containing class. The calling method, testString()
, guarantees that isName()
is always called with a valid string reference. As a result, the class conforms with this rule, even though isName()
in isolation does not. In general, guarantees of this sort can be used to eliminate null pointer dereferences.
Exceptions
EXP01-EX0: A method may dereference an object-typed parameter without guarantee that it is a valid object reference provided that the method documents that it (potentially) throws a NullPointerException
, either via the throws
clause of the method or in the method comments. However, this exception should be relied upon sparingly.
Risk Assessment
Dereferencing a null
pointer can lead to a denial of service. In multithreaded programs, null pointer dereferences can violate cache coherency policies and can cause resource leaks.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
EXP01-J | Low | Likely | High | P3 | L3 |
Automated Detection
Null pointer dereferences can happen in path-dependent ways. Limitations of automatic detection tools can require manual inspection of code [Hovemeyer 2007] to detect instances of null pointer dereferences. Annotations for method parameters that must be non-null can reduce the need for manual inspection by assisting automated null pointer dereference detection; use of these annotations is strongly encouraged.
Tool | Version | Checker | Description |
---|---|---|---|
Coverity | 1.0 | FB.NP_DEREFERENCE_OF_READLINE_VALUE FB.NP_NULL_PARAM_DEREF FB.NP_TOSTRING_COULD_RETURN_NULL FORWARD_NULL NULL_RETURNS FB.NP_DEREFERENCE_OF_READLINE_VALUE | Implemented |
Fortify | 1.0 | Missing_Check_against_Null Null_Dereference Redundant_Null_Check | Implemented |
Findbugs | 1.0 | NP_DEREFERENCE_OF_READLINE_VALUE NP_NULL_PARAM_DEREF NP_TOSTRING_COULD_RETURN_NULL | Implemented |
Related Vulnerabilities
Java Web Start applications and applets particular to JDK version 1.6, prior to update 4, were affected by a bug that had some noteworthy security consequences. In some isolated cases, the application or applet's attempt to establish an HTTPS connection with a server generated a NullPointerException
[SDN 2008]. The resulting failure to establish a secure HTTPS connection with the server caused a denial of service. Clients were temporarily forced to use an insecure HTTP channel for data exchange.
Related Guidelines
Null Pointer Dereference [XYH] | |
CWE-476. NULL pointer dereference |
Android Implementation Details
Android applications are more sensitive to NullPointerException
due to the constraint of the limited mobile device memory. Static members or members of an Activity may become null when memory runs out.
Bibliography