Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Code Block
bgColor#FFCCCC
public class TestWrapper2 {
  public static void main(String[] args) {
  
   
  Integer i1 = 100;
         Integer i2 = 100;
         Integer i3 = 1000;
         Integer i4 = 1000;
         System.out.println(i1==i2);
         System.out.println(i1!=i2);
         System.out.println(i3==i4);
         System.out.println(i3!=i4);
    
  
 }
}

Output of This Code

Here the cache in the Integer class can only make the number from -127 to 128 refer to the same object, which clearly explains the result of the above code. To avoid making such mistakes, when you need to compare wrapper classes, use equal instead of == (see EXP03-J for details).

...

Code Block
bgColor#CCCCFF
public class TestWrapper2 {
  public static void main(String[] args) {
  
    
  Integer i1 = 100;
         Integer i2 = 100;
         Integer i3 = 1000;
         Integer i4 = 1000;
         System.out.println(i1.equals(i2));
         System.out.println(i3.equals(i4));    
 
 }
} 

Noncompliant Code Example

...

Code Block
bgColor#FFCCCC
import java.util.ArrayList;
public class TestWrapper1 {
  public static void main(String[] args) {
    //create an array list of integers, which each element
    //is more than 127
&#xA0;&#xA0;&#xA0;&#xA0;     ArrayList<Integer> list1 = new ArrayList<Integer>();
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0;     &#xA0;list1.add(i+1000);
&#xA0;&#xA0;  //create another array list of integers, which each element
&#xA0;&#xA0;  //is the same with the first one
&#xA0;&#xA0;&#xA0;&#xA0;     ArrayList<Integer> list2 = new ArrayList<Integer>();
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;      list2.add(i+1000);&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;
 
     int counter = 0;
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;      if(list1.get(i) == list2.get(i)) counter++;
&#xA0;&#xA0;&#xA0;&#xA0;     //output the total equal number
&#xA0;&#xA0;&#xA0;&#xA0;     System.out.println(counter);
&#xA0; }
}&#xA0;

In JDK 1.6.0_10, the output of this code is 0. In this code, we want to count the same numbers of array list1 and array list2. Undoubtedly, the result is not what we expect. Integer can only cache from -127 to 128, so when an int number is beyond this range, it will be autoboxed into different objects, and == will return false. But if we can set more caches inside Integer (cache all the integer values -32K-32K, which means that all the int values could be autoboxed to the same Integer object), then the result may be different.

...

Code Block
bgColor#CCCCFF
public class TestWrapper1 {
&#xA0; public static void main(String[] args) {
&#xA0;&#xA0;  //create an array list of integers, which each element
&#xA0;&#xA0;  //is more than 127
&#xA0;&#xA0;&#xA0;&#xA0;     ArrayList<Integer> list1 = new ArrayList<Integer>();
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;      list1.add(i+1000);
&#xA0;&#xA0;  //create another array list of integers, which each element
&#xA0;&#xA0;  //is the same with the first one
&#xA0;&#xA0;&#xA0;&#xA0;     ArrayList<Integer> list2 = new ArrayList<Integer>();
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;      list2.add(i+1000);&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;
 
     int counter = 0;
&#xA0;&#xA0;&#xA0;&#xA0;     for(int i=0;i<10;i++)
&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;      if(list1.get(i).equals(list2.get(i))) counter++;
&#xA0;&#xA0;&#xA0;&#xA0;     //output the total equal number
&#xA0;&#xA0;&#xA0;&#xA0;     System.out.println(counter);
&#xA0; }
}

In JDK 1.6.0_10, the output of this code is 10. (The reason is the same as the above code example.)

...