Page History

...

If execution of the try block completes abruptly for any other reason R, then the finally block is executed. Then there is a choice:
If the finally block completes normally, then the try statement completes abruptly for reason R.
If the finally block completes abruptly for reason S, then the try statement completes abruptly for reason S (and reason R is discarded).

Noncompliant Code Example

In this noncompliant code example, the finally block completes abruptly because of a return statement in the block.

...

The IllegalStateException is suppressed by the abrupt completion of the finally block caused by the return statement.

Compliant Solution

This compliant solution removes the return statement from the finally block.

Code Block

bgColor	#ccccff

class TryFinally {
  private static boolean doLogic() {
    try {
      throw new IllegalStateException();
    } finally {
      System.out.println("logic done");
    }
    // Any return statements must go here; 
    // applicable only when exception is thrown conditionally
  }
}

Exceptions

ERRO4-EX0: Control flow statements whose destination is within the finally block are perfectly acceptable.

...

Code Block

bgColor	#ccccff

class TryFinally {
  private static boolean doLogic() {
    try {
      throw new IllegalStateException();
    } finally {
      int c;
      try {
        while ((c = input.read()) != -1) {
          if (c > 128) {
            break;
          }
        }
      } catch (IOException x) {
        // forward to handler
      }
      System.out.println("logic done");
    }
    // Any return statements must go here; applicable only when exception is thrown conditionally
  }
}

Risk Assessment

Completing abruptly from a finally block masks any exceptions thrown inside the associated try and catch blocks.

Rule	Severity	Likelihood	Remediation Cost	Priority	Level
ERR04-J	low	probable	medium	P4	L3

Related Guidelines

MITRE CWE	CWE-459. Incomplete cleanup
	CWE-584. Return inside finally block

Bibliography

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="58e36fcde1965309-3b7e7e75-47ce4517-b2ea9337-c0d630739a58f0586538ad8f"><ac:plain-text-body><![CDATA[	[[Bloch 2005	AA. References#Bloch 05]]	Puzzle 36. Indecision	]]></ac:plain-text-body></ac:structured-macro>
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="7afb6c616f53220f-ab496caa-445a4a3b-83aba0c3-3b1490892f6eeef65fee109c"><ac:plain-text-body><![CDATA[	[[Chess 2007	AA. References#Chess 07]]	8.2, Managing Exceptions, The Vanishing Exception	]]></ac:plain-text-body></ac:structured-macro>
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="810aa8dad0c512d2-714e7a74-4a1d4e10-b3e28f3b-c6b3e7bb93f50842c25ecb6d"><ac:plain-text-body><![CDATA[	[[JLS 2005	AA. References#JLS 05]]	[§14.20.2, Execution of try-catch-finally	http://java.sun.com/docs/books/jls/third_edition/html/statements.html#14.20.2]	]]></ac:plain-text-body></ac:structured-macro>

...

Space shortcuts

Page tree

Versions Compared

Old Version 83

New Version 84

Key