Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

The write() method, defined in the class java.io.OutputStream, takes an argument of type int intended to be between 0 and 255. Because a value of type int could be outside this range, failure to range check can result in the truncation of the higher-order bits of the input.

Wiki Markup
The general contract for the {{write()}} method says that it writes one byte to the output stream. The byte to be written constitutes the eight lower -order bits of the argument {{b}}, passed to the {{write()}} method; the 24 high-order bits of {{b}} are ignored (see \[[API 2006|AA. Bibliography#API 06]\] [{{java.io.OutputStream.write()}}|http://download.oracle.com/javase/6/docs/api/java/io/OutputStream.html#write(int)] for more information).

...

This noncompliant code example accepts a value from the user without validating it. Any value that is not in the range of 0 to 255 is truncated. For instance, write(303) prints / on ASCII-based systems because the lower-order 8 bits of 303 are used while the 24 high-order bits are ignored (303 % 256 = 47, which is the ASCII code for /). That is, the result is the remainder of the input divided by 256.

Code Block
bgColor#FFcccc
class ConsoleWrite {
  public static void main(String[] args) { 
    // Any input value > 255 will result in unexpected output
    System.out.write(Integer.valueOf(args[0]));
    System.out.flush();
  }
}

...

Perform range checking to be compliant. This compliant solution prints the corresponding character only if the input integer is in the proper range. If the input is outside the representable range of an int, the Integer.valueOf() method throws a NumberFormatException. If the input can be represented by an int, but is outside the range required by write(), this code throws an ArithmeticException.

Code Block
bgColor#ccccff
class FileWrite {
  public static void main(String[] args) throws NumberFormatException, IOException { 

                       FileOutputStream out = new FileOutputStream("output");   

throws NumberFormatException, IOException { 
    // Perform range checking  
    int value = Integer.valueOf(args[0]);
    if (value < 0 || value > 255) {
      throw new ArithmeticException("Value is out of range");
    }
  
    System.out.write(value);
    System.out.flush(); 
  }
}

Compliant Solution (

...

writeInt())

This compliant solution uses the writeInt() method of the DataOutputStream class, which is capable of handling can handle an int.

Code Block
bgColor#ccccff
class FileWrite {
  public static void main(String[] args)
                          throws NumberFormatException, IOException { 
    DataOutputStream dos = new DataOutputStream(System.out);
    dos.writeInt(Integer.valueOf(args[0].toString()));
    System.out.flush(); 
  }     
}

...

MITRE CWE

CWE-252. Unchecked Return Value return value

Bibliography

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="aa7cd98c28a7114a-89d32cc9-41634c21-939f95c5-a557e6b726f561f7d6b1a4e5"><ac:plain-text-body><![CDATA[

[[API 2006

AA. Bibliography#API 06]]

method [Method write()

http://java.sun.com/javase/6/docs/api/java/io/OutputStream.html#write(int)]

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="095d269b8e93a7a4-ec9b4bb5-48bb47b6-83908e7e-c2c6d970679295dbfbaccccf"><ac:plain-text-body><![CDATA[

[[Harold 1999

AA. Bibliography#Harold 99]]

 

]]></ac:plain-text-body></ac:structured-macro>

...