Classes that implement the Externalizable
interface must provide the readExternal()
and writeExternal()
methods. These methods have package or public access, and so they can be called by trusted and untrusted code alike. Consequently, programs must ensure that these methods execute only when intended and that they cannot overwrite the internal state of objects at arbitrary points during program execution.
Noncompliant Code Example
This noncompliant code example allows any caller to reset the value of the object at any time because the readExternal()
method is necessarily declared to be public and lacks protection against hostile callers.
Code Block | ||
---|---|---|
| ||
public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { // Read instance fields this.name = (String)in.readObject(); this.UID = in.readInt(); //... } |
Compliant Solution
This compliant solution protects against multiple initialization through the use of a Boolean flag that is set after the instance fields have been populated. It also protects against race conditions by synchronizing on a private lock object (see LCK00-J. Use private final lock objects to synchronize classes that may interact with untrusted code).
...
Note that this compliant solution is insufficient to protect sensitive data.
Risk Assessment
Failure to prevent the overwriting of externalizable objects can corrupt the state of the object.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
SER11-J | low | probable | low | P6 | L2 |
Bibliography
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="d8e117703fd25a54-8ba477cf-410747b5-b134a8b8-8d0e26f30547db4197c60563"><ac:plain-text-body><![CDATA[ | [[API 2006 | AA. Bibliography#API 06]] |
| ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="121ede075561ae0b-689ea26f-4d614217-b512b7c5-6c99340cf0995a291e121a6d"><ac:plain-text-body><![CDATA[ | [[Sun 2006 | AA. Bibliography#Sun 06]] | "Serialization specification: A.7 Preventing Overwriting of Externalizable Objects" | ]]></ac:plain-text-body></ac:structured-macro> |
...